Matthias Saou wrote:
@@ -25,9 +25,9 @@ BuildRequires: openssl-devel, krb5-devel, libacl-devel BuildRequires: zlib-devel # On RHEL (up to 5 included), the devel part was still in tcp_wrappers -%if 0%{?rhel} <= 5 +# We'll need to find a better way to do this once RHEL6 comes out BuildRequires: tcp_wrappers -%else +%if 0%{?fedora:1} BuildRequires: tcp_wrappers-devel %endif BuildRequires: openldap-devel
A "better way" that I use is:
BuildRequires: /usr/include/tcpd.h
Works everywhere.
Cheers, Paul.
Paul Howarth paul@city-fan.org writes:
Matthias Saou wrote:
+# We'll need to find a better way to do this once RHEL6 comes out
A "better way" that I use is: BuildRequires: /usr/include/tcpd.h Works everywhere.
I think this is discouraged by guidelines because it makes the depsolver work *much* harder to figure out which package the require actually resolves as. At least I know I've been told to avoid it when practical.
Of course, maybe fixing that is just a small performance fix in rpm ...
regards, tom lane
On Tue, 14 Apr 2009, Tom Lane wrote:
Paul Howarth paul@city-fan.org writes:
Matthias Saou wrote:
+# We'll need to find a better way to do this once RHEL6 comes out
A "better way" that I use is: BuildRequires: /usr/include/tcpd.h Works everywhere.
I think this is discouraged by guidelines because it makes the depsolver work *much* harder to figure out which package the require actually resolves as. At least I know I've been told to avoid it when practical.
Of course, maybe fixing that is just a small performance fix in rpm ...
It doesn't make the depsolver work harder. It makes the user/builder download all the filelists metadata to do this look up - so it is a pain for users on slow/bad connections.
-sv
Seth Vidal wrote:
On Tue, 14 Apr 2009, Tom Lane wrote:
Paul Howarth paul@city-fan.org writes:
Matthias Saou wrote:
+# We'll need to find a better way to do this once RHEL6 comes out
A "better way" that I use is: BuildRequires: /usr/include/tcpd.h Works everywhere.
I think this is discouraged by guidelines because it makes the depsolver work *much* harder to figure out which package the require actually resolves as. At least I know I've been told to avoid it when practical.
Of course, maybe fixing that is just a small performance fix in rpm ...
It doesn't make the depsolver work harder. It makes the user/builder download all the filelists metadata to do this look up - so it is a pain for users on slow/bad connections.
It's not a problem in this case though because it's a buildreq that's resolved once on the buildsystem and has no impact on end users at all.
Paul.
On Tuesday, April 14 2009, Seth Vidal said:
On Tue, 14 Apr 2009, Tom Lane wrote:
Paul Howarth paul@city-fan.org writes:
Matthias Saou wrote:
+# We'll need to find a better way to do this once RHEL6 comes out
A "better way" that I use is: BuildRequires: /usr/include/tcpd.h Works everywhere.
I think this is discouraged by guidelines because it makes the depsolver work *much* harder to figure out which package the require actually resolves as. At least I know I've been told to avoid it when practical.
Of course, maybe fixing that is just a small performance fix in rpm ...
It doesn't make the depsolver work harder. It makes the user/builder download all the filelists metadata to do this look up - so it is a pain for users on slow/bad connections.
That said, for a BuildRequires, it's not terrible. If you're looking to build, you're already going to be downloading a lot and the filelists are kind of a drop in the bucket.
I think the guidelines are pretty explicit about it being discouraged for regular requires and not buildrqeuires, but it's been a while since I looked at that chunk
Jeremy