Hi everybody,
I've been putting together package Review Requests for all the golang package dependencies of syncthing (an open source file synchronization service). Some of them have already been reviewed (thank you, Jan! I feel much more confident about my golang packaging now), but there are still 16 packages left.
The packages are (mostly) very simple (standard golang specs generated by gofed), and I've added explanatory comments where they differ from the automatically generated gofed output for the repository in question. I've marked inter-dependencies between the packages as blockers / dependencies in bugzilla, but included them below for easy reference. The full dependency graph can be seen at https://decathorpe.fedorapeople.org/packages/DependencyGraph.png.
Packages without blockers / missing dependencies:
1) golang-github-edsrzf-mmap-go - Portable mmap package for Go https://bugzilla.redhat.com/show_bug.cgi?id=1431568
2) golang-github-cznic-mathutil - Supplemental utilities for Go's rand and math packages https://bugzilla.redhat.com/show_bug.cgi?id=1431587
3) golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go https://bugzilla.redhat.com/show_bug.cgi?id=1431759
4) golang-github-AudriusButkevicius-cli - Small library for building CLI apps in Go https://bugzilla.redhat.com/show_bug.cgi?id=1431761
5) golang-github-zillode-notify - File system event notification library on steroids https://bugzilla.redhat.com/show_bug.cgi?id=1431867
Packages depending on one of the packages above:
6) golang-github-cznic-fileutil - File utility functions for Go (depends on [2]) https://bugzilla.redhat.com/show_bug.cgi?id=1431732
7) golang-github-cznic-sortutil - Supplemental utilities for Go's sort package (depends on [2]) https://bugzilla.redhat.com/show_bug.cgi?id=1431735
8) golang-github-cznic-strutil - Supplemental utilities for Go's strings package (depends on [2]) https://bugzilla.redhat.com/show_bug.cgi?id=1431736
9) golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go (depends on [3]) https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Packages further down the "dependency graph":
10) golang-github-cznic-internal - Shared dependencies for other cznic Go libraries (depends on [1], [2] and [6]) https://bugzilla.redhat.com/show_bug.cgi?id=1431740
11) golang-github-cznic-b - B+ Tree implementation in Go (depends on [2], [6] and [8]) https://bugzilla.redhat.com/show_bug.cgi?id=1431741
12) golang-github-cznic-zappy - Block-based compression format implementation in Go (depends on [10]) https://bugzilla.redhat.com/show_bug.cgi?id=1431743
13) golang-github-cznic-lldb - Low-level database engine implementation in Go (depends on [2], [6], [7], [10] and [12]) https://bugzilla.redhat.com/show_bug.cgi?id=1431745
14) golang-github-cznic-ql - Embedded SQL database written in Go (depends on [2], [8], [11] and [13]) https://bugzilla.redhat.com/show_bug.cgi?id=1431748
15) syncthing - Continuous File Synchronization (depends on [4], [9] and [14]) https://bugzilla.redhat.com/show_bug.cgi?id=1427634
16) syncthing-inotify - Syncthing File watcher (depends on [5] and [15]) https://bugzilla.redhat.com/show_bug.cgi?id=1431868
Any help in getting syncthing into fedora is very much appreciated!
Fabio
On Mon, Mar 13, 2017 at 10:52:06PM +0000, Fabio Valentini wrote:
- golang-github-edsrzf-mmap-go - Portable mmap package for Go
This is duplicated (closed)
- golang-github-cznic-mathutil - Supplemental utilities for Go's rand and
math packages https://bugzilla.redhat.com/show_bug.cgi?id=1431587
This is duplicated (closed)
- golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go
I took this one
- golang-github-zillode-notify - File system event notification library on
steroids https://bugzilla.redhat.com/show_bug.cgi?id=1431867
I took this one as well
Would you be able to review these packages (simple golang packages as well)?
https://bugzilla.redhat.com/show_bug.cgi?id=1394576 https://bugzilla.redhat.com/show_bug.cgi?id=1426965
On Mon, Mar 13, 2017 at 6:52 PM, Fabio Valentini decathorpe@gmail.com wrote:
- golang-github-cznic-sortutil - Supplemental utilities for Go's sort
package (depends on [2]) https://bugzilla.redhat.com/show_bug.cgi?id=1431735
- golang-github-cznic-strutil - Supplemental utilities for Go's strings
package (depends on [2]) https://bugzilla.redhat.com/show_bug.cgi?id=1431736
I took these two; I'll review them once the dependencies get reviewed.
I also have two small golang packages in the review queue, any chance you could look at them in return?
https://bugzilla.redhat.com/show_bug.cgi?id=1411962 https://bugzilla.redhat.com/show_bug.cgi?id=1411961
Ben Rosser
- golang-github-cznic-fileutil - File utility functions for Go (depends on
I will take this as well, would you take a look at https://bugzilla.redhat.com/show_bug.cgi?id=1394923 ?
Thanks!