I'm trying to update the "pl" package, and I'm getting the error in the Subject header when I try to change the list of source files via make new-sources SOURCES="a b c" I'm sure I'm doing this from within the correct directories, and I'm also fairly sure that the same command worked about an hour ago. The whole makefile aspect of package maintenance is basically magic to me -- what could be wrong?
Thanks,
MEF
On Wed, 25 Feb 2009 11:47:51 +0100, Mary wrote:
I'm trying to update the "pl" package, and I'm getting the error in the Subject header when I try to change the list of source files via make new-sources SOURCES="a b c" I'm sure I'm doing this from within the correct directories, and I'm also fairly sure that the same command worked about an hour ago. The whole makefile aspect of package maintenance is basically magic to me -- what could be wrong?
Try: make new-sources FILES="..."
On Wed, Feb 25, 2009 at 11:59 AM, Michael Schwendt mschwendt@gmail.com wrote:
On Wed, 25 Feb 2009 11:47:51 +0100, Mary wrote:
make new-sources SOURCES="a b c"
Try: make new-sources FILES="..."
Oh. Whoops. *blush* ... of course, that works. I knew it was something silly like that but I just couldn't see it.
MEF
On Wed, 25 Feb 2009 13:06:45 +0100, Mary wrote:
On Wed, Feb 25, 2009 at 11:59 AM, Michael Schwendt mschwendt@gmail.com wrote:
On Wed, 25 Feb 2009 11:47:51 +0100, Mary wrote:
make new-sources SOURCES="a b c"
Try: make new-sources FILES="..."
Oh. Whoops. *blush* ... of course, that works. I knew it was something silly like that but I just couldn't see it.
It could be fixed:
diff -u -r1.120 Makefile.common --- Makefile.common 11 Nov 2008 17:55:32 -0000 1.120 +++ Makefile.common 25 Feb 2009 12:52:31 -0000 @@ -308,6 +308,9 @@ @if grep "^/sources/" CVS/Entries >/dev/null; then true ; else cvs -Q add sources; fi @echo "Source upload succeeded. Don't forget to commit the new ./sources file" @cvs update sources .cvsignore +else +upload new-source new-sources: + @if test -z "${FILES}" ; then echo "FILES variable not set!" ; fi endif
# allow overriding buildarch so you can do, say, an i386 build on x86_64
Or even:
diff -u -r1.121 Makefile.common --- Makefile.common 22 Dec 2008 03:55:42 -0000 1.121 +++ Makefile.common 25 Feb 2009 12:56:30 -0000 @@ -308,6 +308,9 @@ @if grep "^/sources/" CVS/Entries >/dev/null; then true ; else cvs -Q add sources; fi @echo "Source upload succeeded. Don't forget to commit the new ./sources file" @cvs update sources .cvsignore +else +upload new-source new-sources: + @echo "FILES variable not set!" endif
# allow overriding buildarch so you can do, say, an i386 build on x86_64
Michael Schwendt wrote:
Or even:
diff -u -r1.121 Makefile.common --- Makefile.common 22 Dec 2008 03:55:42 -0000 1.121 +++ Makefile.common 25 Feb 2009 12:56:30 -0000 @@ -308,6 +308,9 @@ @if grep "^/sources/" CVS/Entries >/dev/null; then true ; else cvs -Q add sources; fi @echo "Source upload succeeded. Don't forget to commit the new ./sources file" @cvs update sources .cvsignore +else +upload new-source new-sources:
- @echo "FILES variable not set!"
endif
# allow overriding buildarch so you can do, say, an i386 build on x86_64
Applied. Thanks!
-Toshio