On Tue, 2011-08-09 at 11:11 -0400, Tom Lane wrote:
Looks fine to me. The only reason I have to dislike it is the temptation for people to inspect build logs as a proof of what flags a package was built with (since the only sane thing is to store that in the binary itself, which the tools team is working on). But for debugging build failures this is great.
What happens in packages using a (possibly old) autoconf script that doesn't recognize --disable-silent-rules?
IMO it would be better to add this option to the %configure calls in packages where it's actually an issue (which is surely a small minority, unless Colin has got evidence to the contrary).
Hi, I would like you to give me an option to not use --disable-silent-rules, because it breaks waf build. I was just trying to build samba4 update for rawhide and I got this [1]:
+ ./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --disable-silent-rules --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-modulesdir=/usr/lib64/samba --with-lockdir=/var/lib/samba4 --with-piddir=/var/run --with-privatedir=/var/lib/samba4/private --with-sockets-dir=/var/run --sysconfdir=/etc/samba4 --datadir=/usr/share/samba --disable-gnutls --disable-rpath-install --builtin-libraries=ccan,wbclient '--bundled-libraries=heimdal,!talloc,!tdb,!tevent,!ldb,!zlib' waf [command] [options] Main commands (example: ./waf build -j4) build : build all targets clean : removes the build files configure : configures the project ctags : build 'tags' file using ctags dist : makes a tarball for distribution distcheck : test that distribution tarball builds and installs distclean : removes the build directory etags : build TAGS file using etags install : installs the build files pydoctor : build python apidocs reconfigure : reconfigure if config scripts have changed test : Run the test suite (see test options below) testonly : run tests without doing a build first uninstall : removes the installed files wafdocs : build wafsamba apidocs wildcard_cmd: called on a unknown command waf: error: no such option: --disable-silent-rules error: Bad exit status from /var/tmp/rpm-tmp.5kugM6 (%build) Bad exit status from /var/tmp/rpm-tmp.5kugM6 (%build) RPM build errors: Child returncode was: 1 EXCEPTION: Command failed. See logs for output.
Thus even autoconf is fine, then waf build system is not.
Could Colin fix this, please? Thanks in advance and bye, Milan
[1]http://koji.fedoraproject.org/koji/getfile?taskID=3265556&name=build.log