On Thu, Jun 27, 2024 at 08:27:00AM +0300, Panu Matilainen wrote:
On 6/26/24 20:03, Stephen Smoogen wrote:
On Wed, 26 Jun 2024 at 10:32, Ron Olson tachoknight@gmail.com wrote:
Hey all-
I’m trying to build Swift 6 on Rawhide and it looks like it gets to the very end, to the %install section, then errors out with:
- /usr/bin/add-determinism --brp -j4 /home/rolson/rpmbuild/BUILD/swift-lang-6.0-build/BUILDROOT
Error: Path "/home/rolson/rpmbuild/BUILD/swift-lang-6.0-build/BUILDROOT" is outside of $RPM_BUILD_ROOT error: Bad exit status from /var/tmp/rpm-tmp.EbjPHr (%install)
Never, ever seen that particular message. I’m assuming the RPM build tools on Rawhide are newer and perhaps there’s something I should be adding to my spec file that I’m not aware of, as often is the case. :\
Does it happen to any spec rebuild or just this one? And if this one what is the spec file? The /home/rolson/rpmbuild/BUILD/swift-lang-6.0-build/BUILDROOT is outside of the buildroot as that should be /home/rolson/rpmbuild/BUILDROOT/ so I could see a bad definition somewhere trying to set up a copy to the wrong destination
/home/rolson/rpmbuild/BUILD/swift-lang-6.0-build/BUILDROOT is the new-style buildroot path in rpm >= 4.20 and so is actually expected in rawhide. It'd only be outside if this was somehow mixed with an older rpm and I don't see how that could happen.
add-determinism has a check that when called via the rpm macros, it requires that $RPM_BUILD_ROOT is defined, not empty, and all the path arguments are below it. I thought it prudent to add such a check in case I mess something up in the definitions ;)
I also remember considering whether to print out the value of $RPM_BUILD_ROOT in that error message and thinking "oh, this should never trigger, no need". I added the printing of RPM_BUILD_ROOT now [1], but I can't push it to rawhide because dist-git is broken [2].
In the meantime, can you post the full build log somewhere?
(As a work-around, you can do '%undefine __brp_add_determinism' in the spec file or '--undefine __brp_add_determinism' on the commnand line to skip that step.)
[1] https://github.com/keszybz/add-determinism/commit/36401dbb22bf1034b2791bd7d5... [2] https://pagure.io/releng/issue/12181
Zbyszek