Hi all,
I would like to ask as Vim co-maintainer, do you find useful for Vim to do:
- when you open new file with .spec suffix, Vim will get you basic spec file structure?
Recently I found out someone can find it as bad behavior https://bugzilla.redhat.com/show_bug.cgi?id=1724126 , so I consider changing the default vimrc to tell Vim 'Don't do it'.
What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled?
On 7/18/19 1:44 PM, Zdenek Dohnal wrote:
Hi all,
I would like to ask as Vim co-maintainer, do you find useful for Vim to do:
- when you open new file with .spec suffix, Vim will get you basic spec
file structure?
Recently I found out someone can find it as bad behavior https://bugzilla.redhat.com/show_bug.cgi?id=1724126 , so I consider changing the default vimrc to tell Vim 'Don't do it'.
What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled?
Generally, I find templates very useful, but I use the vim-template plugin for that, and I was surprised to see that vim ships its own template just for SPECs. Imo, everyone who wants a template should use a plugin. Shipping one by default just for SPECs is somewhat inconsistent.
Kind regards, Till
On 7/18/19 7:44 AM, Zdenek Dohnal wrote:
Hi all,
I would like to ask as Vim co-maintainer, do you find useful for Vim to do:
- when you open new file with .spec suffix, Vim will get you basic spec
file structure?
Recently I found out someone can find it as bad behavior https://bugzilla.redhat.com/show_bug.cgi?id=1724126 , so I consider changing the default vimrc to tell Vim 'Don't do it'.
What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled?
I've never had a problem with it, but then I only edit rpm spec files.
If you were to remove it from /etc/vimrc, would the normal syntax system still provide a good way to edit rpm spec files?
Steve
On 7/18/19 3:25 PM, Steven A. Falco wrote:
On 7/18/19 7:44 AM, Zdenek Dohnal wrote:
Hi all,
I would like to ask as Vim co-maintainer, do you find useful for Vim to do:
- when you open new file with .spec suffix, Vim will get you basic spec
file structure?
Recently I found out someone can find it as bad behavior https://bugzilla.redhat.com/show_bug.cgi?id=1724126 , so I consider changing the default vimrc to tell Vim 'Don't do it'.
What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled?
I've never had a problem with it, but then I only edit rpm spec files.
If you were to remove it from /etc/vimrc, would the normal syntax system still provide a good way to edit rpm spec files?
Yep, AFAIK syntax while editing spec will not be changed - just providing basic spec file structure will be removed (you will have plain file) when you create new spec file. That could be useful for people who creates new package from scratch though...
Steve
devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Hello, Zdenek Dohnal.
Thu, 18 Jul 2019 13:44:56 +0200 you wrote:
What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled?
I think, that *.spec files on Fedora should be treated as RPM SPEC files by default.
-- Sincerely, Vitaly Zaitsev (vitaly@easycoding.org)
On 7/18/19 3:39 PM, Vitaly Zaitsev via devel wrote:
Hello, Zdenek Dohnal.
Thu, 18 Jul 2019 13:44:56 +0200 you wrote:
What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled?
I think, that *.spec files on Fedora should be treated as RPM SPEC files by default.
Even the new .spec files, which do not have to be RPM spec files? Because Vim provides spec template for such cases.
-- Sincerely, Vitaly Zaitsev (vitaly@easycoding.org) _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Le 2019-07-18 15:51, Zdenek Dohnal a écrit :
On 7/18/19 3:39 PM, Vitaly Zaitsev via devel wrote:
Hello, Zdenek Dohnal.
Thu, 18 Jul 2019 13:44:56 +0200 you wrote:
What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled?
I think, that *.spec files on Fedora should be treated as RPM SPEC files by default.
Even the new .spec files, which do not have to be RPM spec files? Because Vim provides spec template for such cases.
There’s no shame in shipping Fedora software with defaults oriented towards Fedora needs. Software needs to have default settings. Default-less unconfigured apps are just painful to use.
Having httpd default to realaudio mime types for rpm files was quite painful…
Hello, Zdenek Dohnal.
Thu, 18 Jul 2019 15:51:33 +0200 you wrote:
Even the new .spec files, which do not have to be RPM spec files? Because Vim provides spec template for such cases.
I never used this feature, so I think it can be disabled by default. But syntax highlighting for RPM SPEC files should be enabled.
-- Sincerely, Vitaly Zaitsev (vitaly@easycoding.org)
On 7/18/19 4:10 PM, Vitaly Zaitsev via devel wrote:
Hello, Zdenek Dohnal.
Thu, 18 Jul 2019 15:51:33 +0200 you wrote:
Even the new .spec files, which do not have to be RPM spec files? Because Vim provides spec template for such cases.
I never used this feature, so I think it can be disabled by default.
That's the thing which I asked for opinion on, not about syntax highlighting.
But syntax highlighting for RPM SPEC files should be enabled.
-- Sincerely, Vitaly Zaitsev (vitaly@easycoding.org) _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
On 7/18/19 10:28 AM, Zdenek Dohnal wrote:
On 7/18/19 4:10 PM, Vitaly Zaitsev via devel wrote:
Hello, Zdenek Dohnal.
Thu, 18 Jul 2019 15:51:33 +0200 you wrote:
Even the new .spec files, which do not have to be RPM spec files? Because Vim provides spec template for such cases.
I never used this feature, so I think it can be disabled by default.
That's the thing which I asked for opinion on, not about syntax highlighting.
Ah - now I understand. I thought you were asking about syntax highlighting.
I had never noticed the feature of creating a new spec file from a template, because I have my own .vimrc file, so the /etc/vimrc file has no effect for me.
I think having a template for just this single file type is kind of "strange". I'd personally be fine with removing that line from /etc/vimrc. I'd expect users who want templates to set them up for themselves, rather than forcing users to disable templates they don't want.
Steve
On 7/18/19 6:44 PM, Steven A. Falco wrote:
On 7/18/19 10:28 AM, Zdenek Dohnal wrote:
On 7/18/19 4:10 PM, Vitaly Zaitsev via devel wrote:
Hello, Zdenek Dohnal.
Thu, 18 Jul 2019 15:51:33 +0200 you wrote:
Even the new .spec files, which do not have to be RPM spec files? Because Vim provides spec template for such cases.
I never used this feature, so I think it can be disabled by default.
That's the thing which I asked for opinion on, not about syntax highlighting.
Ah - now I understand. I thought you were asking about syntax highlighting.
I had never noticed the feature of creating a new spec file from a template, because I have my own .vimrc file, so the /etc/vimrc file has no effect for me.
That's not true (at least on my machine). I have my own .vimrc and yet the template is loaded when I create a new spec.
I think having a template for just this single file type is kind of "strange". I'd personally be fine with removing that line from /etc/vimrc. I'd expect users who want templates to set them up for themselves, rather than forcing users to disable templates they don't want.
Yes, that's exactly what I thought. We also have rpmdev-newspec, which I typically use if I create a spec file for a Fedora package. It's irritating that they're different.
Kind regards, Till
Hello, Till Hofmann.
Fri, 19 Jul 2019 08:46:50 +0200 you wrote:
We also have rpmdev-newspec
Btw, someone need to remove from templates, used by this tool, this row: rm -rf $RPM_BUILD_ROOT. It forbidden by modern packaging guidelines.
-- Sincerely, Vitaly Zaitsev (vitaly@easycoding.org)
"ZD" == Zdenek Dohnal zdohnal@redhat.com writes:
ZD> Hi all, I would like to ask as Vim co-maintainer, do you find useful ZD> for Vim to do:
ZD> - when you open new file with .spec suffix, Vim will get you basic ZD> spec file structure?
Personally I have always found that behavior annoying. If I open a new file, I expect that the file would be empty. If I want a template, I can copy one. Editing a new HTML file doesn't bring up a template for HTML files, for example.
The spec template used isn't something I ever want anyway. It uses tabs instead of spaces and uses them in a way that implies that indentation is somehow required. And it includes a default release tag of "0%{?dist}" which isn't permitted by the packaging guidelines. (Releases start at one except when packaging prerelease software, and are never exactly zero.)
Best to leave it to the packager to choose their own template, or to allow somehow who wants templating behavior to configure templating in a general way.
- J<
On 7/18/19 9:47 PM, Jason L Tibbitts III wrote:
"ZD" == Zdenek Dohnal zdohnal@redhat.com writes:
ZD> Hi all, I would like to ask as Vim co-maintainer, do you find useful ZD> for Vim to do:
ZD> - when you open new file with .spec suffix, Vim will get you basic ZD> spec file structure?
Personally I have always found that behavior annoying. If I open a new file, I expect that the file would be empty. If I want a template, I can copy one. Editing a new HTML file doesn't bring up a template for HTML files, for example.
The spec template used isn't something I ever want anyway. It uses tabs instead of spaces and uses them in a way that implies that indentation is somehow required.
Converted to spaces now.
And it includes a default release tag of "0%{?dist}" which isn't permitted by the packaging guidelines.
Expected. It is designed for user to run rpmdev-bumpspec <package>.spec, so the tool will supply correct format of changelog entry and increment the release.
(Releases start at one except when packaging prerelease software, and are never exactly zero.)
Best to leave it to the packager to choose their own template, or to allow somehow who wants templating behavior to configure templating in a general way.
- J<
On Fri, 19 Jul 2019 at 05:09, Zdenek Dohnal zdohnal@redhat.com wrote:
On 7/18/19 9:47 PM, Jason L Tibbitts III wrote:
> "ZD" == Zdenek Dohnal zdohnal@redhat.com writes:
ZD> Hi all, I would like to ask as Vim co-maintainer, do you find useful ZD> for Vim to do:
ZD> - when you open new file with .spec suffix, Vim will get you basic ZD> spec file structure?
Personally I have always found that behavior annoying. If I open a new file, I expect that the file would be empty. If I want a template, I can copy one. Editing a new HTML file doesn't bring up a template for HTML files, for example.
The spec template used isn't something I ever want anyway. It uses tabs instead of spaces and uses them in a way that implies that indentation is somehow required.
Converted to spaces now.
And it includes a default release tag of "0%{?dist}" which isn't permitted by the packaging guidelines.
Expected. It is designed for user to run rpmdev-bumpspec <package>.spec, so the tool will supply correct format of changelog entry and increment the release.
Why would you use rpmdev-bumpspec for a file created in vim when you can use <leader>c in vim directly?
(Releases start at one except when packaging prerelease software, and are never exactly zero.)
Best to leave it to the packager to choose their own template, or to allow somehow who wants templating behavior to configure templating in a general way.
- J<
-- Zdenek Dohnal Software Engineer Red Hat Czech - Brno TPB-C
devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
On 7/19/19 11:33 AM, Elliott Sales de Andrade wrote:
On Fri, 19 Jul 2019 at 05:09, Zdenek Dohnal zdohnal@redhat.com wrote:
On 7/18/19 9:47 PM, Jason L Tibbitts III wrote:
>> "ZD" == Zdenek Dohnal zdohnal@redhat.com writes:
ZD> Hi all, I would like to ask as Vim co-maintainer, do you find useful ZD> for Vim to do:
ZD> - when you open new file with .spec suffix, Vim will get you basic ZD> spec file structure?
Personally I have always found that behavior annoying. If I open a new file, I expect that the file would be empty. If I want a template, I can copy one. Editing a new HTML file doesn't bring up a template for HTML files, for example.
The spec template used isn't something I ever want anyway. It uses tabs instead of spaces and uses them in a way that implies that indentation is somehow required.
Converted to spaces now.
And it includes a default release tag of "0%{?dist}" which isn't permitted by the packaging guidelines.
Expected. It is designed for user to run rpmdev-bumpspec <package>.spec, so the tool will supply correct format of changelog entry and increment the release.
Why would you use rpmdev-bumpspec for a file created in vim when you can use <leader>c in vim directly?
It also creates a changelog entry for you.
"ZD" == Zdenek Dohnal zdohnal@redhat.com writes:
ZD> Converted to spaces now.
Well I appreciate that, but my point is that it's really personal preference.
ZD> It is designed for user to run rpmdev-bumpspec ZD> <package>.spec, so the tool will supply correct format of changelog ZD> entry and increment the release.
That seems to be rather abstruse. I mean, by default vim can already add a proper changelog entry directly (assuming you're not doing anything "interesting" with Version: and Release:). It doesn't seem logical to present an invalid specfile by default and then force someone to run an external tool to make it valid. If an external step is always required, wouldn't it make more sense to have that step be the initial copying of the user's preferred template into place?
- J<
Although I'm not vim + .spec file user, I'm a big fan of templates and a big hater of autotemplating without my explicit decision in general =)
19/7/18 13:44(e)an, Zdenek Dohnal igorleak idatzi zuen:
Hi all,
I would like to ask as Vim co-maintainer, do you find useful for Vim to do:
- when you open new file with .spec suffix, Vim will get you basic spec
file structure?
Recently I found out someone can find it as bad behavior https://bugzilla.redhat.com/show_bug.cgi?id=1724126 , so I consider changing the default vimrc to tell Vim 'Don't do it'.
What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled?
devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
I won't miss it. For Ruby, I would suggest everybody to use gem2rpm instead and there are similar tools for different language eccosystems. But if somebody should miss the template, may be it could go into subpackage, which would be installed together with fedora-packager package or so.
Vít
Dne 18. 07. 19 v 13:44 Zdenek Dohnal napsal(a):
Hi all,
I would like to ask as Vim co-maintainer, do you find useful for Vim to do:
- when you open new file with .spec suffix, Vim will get you basic spec
file structure?
Recently I found out someone can find it as bad behavior https://bugzilla.redhat.com/show_bug.cgi?id=1724126 , so I consider changing the default vimrc to tell Vim 'Don't do it'.
What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled?
devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org