Thank you Daniel and Richard. I'm going to have to study this some to understand how this solves the compile issue cause the glibc code isn't gone. It's still there.
Carol
On Wed, Mar 3, 2021 at 11:31 AM Richard W.M. Jones rjones@redhat.com wrote:
On Wed, Mar 03, 2021 at 02:24:35PM +0000, Daniel P. Berrangé wrote:
On Wed, Mar 03, 2021 at 09:07:48AM -0500, Carol Bouchard wrote:
I'm seeing the following compile error in my product which I'm not
seeing
with earlier versions of Fedora.
*make[4]: Entering directory '/builddir/build/BUILD/restraint-0.3.2/third-party/m4-1.4.18/lib' CC gl_avltree_oset.o CC binary-io.o CC c-ctype.o CC c-stack.oIn file included from /usr/include/signal.h:315, from ./signal.h:52, from c-stack.c:49:c-stack.c:55:26: error: missing binary operator before token "(" 55 | #elif HAVE_LIBSIGSEGV && SIGSTKSZ < 16384 | ^~~~~~~~*
In earlier fedora versions, SIGSTKSZ is a numeric value. In rawhide,
I'm
seeing the following in file /usr/include/bits/sigstksz.h.
*/* Default stack size for a signal handler: sysconf (SC_SIGSTKSZ).
*/#
undef SIGSTKSZ# define SIGSTKSZ sysconf (_SC_SIGSTKSZ)*
This looks like an issue to be addressed in Fedora and not by applying
a
patch. Please advise.
The glibc change was intentionale and unavoidable per this previous thread:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...
So you'll need to patch the application so that it doesn't make an assumption that SIGSTKSZ evaluates to a static constant.
FWIW these were the two proposed fixes for this in OCaml (the second one was accepted). Not too bad, you just have to be aware that the structure can no longer be statically allocated:
https://pagure.io/fedora-ocaml/c/dfb5e954a04f59b0456cc4c0ddf3acaf22e0ff07?br...
https://github.com/ocaml/ocaml/pull/10266/files
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure