On 25. 10. 19 13:17, Miro Hrončok wrote:
On 25. 10. 19 12:23, Miro Hrončok wrote:
On 24. 10. 19 13:30, Peter Robinson wrote:
On Thu, Oct 24, 2019 at 11:48 AM Miro Hrončok <mhroncok@redhat.com mailto:mhroncok@redhat.com> wrote: How do I find our why is Python 2 in the critical path?
Does running scripts/get-critpath from the releng repo give any insight?
No luck so far:
...
$ python get-critpath f31 Traceback (most recent call last): File "get-critpath", line 52, in <module> main() File "get-critpath", line 29, in main pdc = pdc_client.PDCClient('fedora') File "/usr/lib/python3.7/site-packages/pdc_client/__init__.py", line 238, in __init__ token = self.obtain_token() File "/usr/lib/python3.7/site-packages/pdc_client/__init__.py", line 252, in obtain_token return self.auth[end_point]._(page_size=None)['token'] File "/usr/lib/python3.7/site-packages/pdc_client/__init__.py", line 347, in __call__ return self.client(*args, **kwargs) File "/usr/lib/python3.7/site-packages/beanbag/namespace.py", line 136, in fn *args, **kwargs) File "/usr/lib/python3.7/site-packages/beanbag/url_v1.py", line 102, in call return self.make_request(path, verb, kwargs, body) File "/usr/lib/python3.7/site-packages/beanbag/url_v1.py", line 155, in make_request "Bad response code: %d" % (r.status_code,)) beanbag.bbexcept.BeanBagException: Bad response code: 401
I've been able to run the script with:
diff --git a/scripts/get-critpath b/scripts/get-critpath index fc6c6f0..eb1557c 100755 --- a/scripts/get-critpath +++ b/scripts/get-critpath @@ -26,13 +26,13 @@ def main(): parser = setup_args() args = parser.parse_args()
- pdc = pdc_client.PDCClient('fedora') + pdc = pdc_client.PDCClient('fedora', develop=True)
endpoint = pdc['component-branches'] kwargs = dict(name=args.branch, active=True) existing = pdc.get_paged(endpoint, **kwargs) try: - existing.next() + next(existing) except StopIteration: print("%s not a valid branch." % args.branch, file=sys.stderr) sys.exit(1)
It just gives me a list of packages, including python2, but no insights.
The critpath.py script from the same place is quite more interesting, as it actually resolves the critpath on various architectures instead of querying an API where I already know python2 is listed in.
With this patch: https://pagure.io/releng/pull-request/8935
$ python3 critpath.py --dnf branched
does not add python2 for any of the following architectures:
1145 packages for armhfp/armv7hl 1156 packages for aarch64 1176 packages for x86_64 1210 packages for ppc64le 1198 packages for s390x