Hi,
let me introduce quickly. I'm Uwe Gansert and I'm working for Novell in Nuremberg Germany where one of my main tasks is to maintain AutoYaST.
While I was working on SUSE Manager too (which is based on the Spacewalk project) I stumbled across cobbler and I built packages for openSUSE 11.4 and SLES11. While doing so, I did some patches that I want to sent you now and I hope we can discuss about them and use them later in the upstream. I did the patches today against git master.
As you can see, the patch for autoyast support and for supporting the different pathes on SUSE are the biggest ones.
I'm not sure if you like the way I fixed the pathes problem but at least you can use the patch to see where we have problems with pathes on SUSE.
The autoyast patch should make no trouble. It does not touch kickstart code but just enhances cobbler to be able to deal with autoyast XML files.
Feel free to use the patches and if you have questions, just ask. That was my first time I got in touch with python so maybe it looks a bit perlish sometimes ;)
I have a patch for the init-script and the spec file too. I'll send them later, they need some more cleanup.
On Mon, 7 Mar 2011 14:25:52 +0100, Uwe Gansert ug@suse.de wrote:
Hi,
let me introduce quickly. I'm Uwe Gansert and I'm working for Novell in Nuremberg Germany where one of my main tasks is to maintain AutoYaST.
While I was working on SUSE Manager too (which is based on the Spacewalk project) I stumbled across cobbler and I built packages for openSUSE 11.4 and SLES11. While doing so, I did some patches that I want to sent you now and I hope we can discuss about them and use them later in the upstream. I did the patches today against git master.
As you can see, the patch for autoyast support and for supporting the different pathes on SUSE are the biggest ones.
I'm not sure if you like the way I fixed the pathes problem but at least you can use the patch to see where we have problems with pathes on SUSE.
The autoyast patch should make no trouble. It does not touch kickstart code but just enhances cobbler to be able to deal with autoyast XML files.
Feel free to use the patches and if you have questions, just ask. That was my first time I got in touch with python so maybe it looks a bit perlish sometimes ;)
I have a patch for the init-script and the spec file too. I'll send them later, they need some more cleanup.
Can you put a repo up on github? It is much easier to exchange patches that way. Thanks.
on Monday 07 March 2011 Scott Henson wrote:
Can you put a repo up on github? It is much easier to exchange patches that way. Thanks.
okay, I did so: https://github.com/ugansert/Cobbler
On Wed, 9 Mar 2011 15:09:50 +0100, Uwe Gansert ug@suse.de wrote:
on Monday 07 March 2011 Scott Henson wrote:
Can you put a repo up on github? It is much easier to exchange patches that way. Thanks.
okay, I did so: https://github.com/ugansert/Cobbler
Nice, it all looks good except the following bit.
diff --git a/cobbler/remote.py b/cobbler/remote.py index 0e6b8dd..a692670 100644 --- a/cobbler/remote.py +++ b/cobbler/remote.py @@ -92,7 +92,7 @@ class CobblerThread(Thread): try: rc = self._run(self) self.remote._set_task_state(self,self.event_id,EVENT_COMPLETE) - self.on_done() + self.on_done return rc except: utils.log_exc(self.logger)
That should be calling the method. I believe we just merged a patch to fix that recently.
cobbler-devel@lists.fedorahosted.org