Hi James, others,
If i adjust the code to something like:
if systems is not None: # this check isn't really needed
anymore since it's done in the utils function aswell
which_systems = utils.input_string_or_list(systems)
else:
which_systems = []
The behaviour from the CLI will be like this:
[root@daemon /]# cobbler buildiso --systems="x doosje"
Which is ok by me, but it isn't very consistent with other CLI commands, e.g.:
[root@daemon /]# cobbler profile report --name="bla natty"
No profile found: bla natty
Is this approach, in your opinion, still okay for buildiso?
Shouldn't we ideally make this behaviour the same for all other commands too?
Thoughts?
Grtz,
Jörgen Maas
On Sat, Aug 20, 2011 at 1:48 PM, Jörgen Maas <jorgen.maas(a)gmail.com> wrote:
On Sat, Aug 20, 2011 at 1:35 PM, James Cammarata
<jimi(a)sngx.net> wrote:
<snip>
> I would like to see this code use the input_string_or_list() function
> from utils.py. It has always annoyed me that buildiso is the only
> function that takes a list separated by commas instead of spaces.
Good suggestion, i will look into this and come up with a better patch.
Thanks a lot for the review!
Grtz,
Jörgen Maas