Excerpts from Vreman, Peter's message of Tue Jan 12 05:51:13 -0500 2010:
Koan:
+ afda8a88249ed3a124651a25fc52e9f78d1ab414 update string_to_hash and
hash_to_string from cobblerd to support multiple kernel options with the same
name
Instead of type(hash) != dict, try isinstance(hash, dict), it should
catch subclasses of dict as well. Otherwise this patch looks good.
Logging improvements for background tasks:
+ 90c00b3abba0d15a2e6857469ea24fad00f95b0b make sync actions always verbose,
before the copy actions were only logged without context
Why? The patch looks good, just curious why make sync actions always verbose?
+ 1a09c11eb2c546d53c366b26ab4acce96d3bc314 logging for creation of
dhcp and dns
configurations
+ 9867963dc8eb11052ec3521c5baf18803fe826e9 log creation of pxe files
+ 9ee3887130fe2beb49d332a3420166398595242d log updates, add criteria to
find_items and make more debug
Same question, otherwise looks good. Making the items debug makes
sense though.
CLI error handling:
+ e9d0cf90df35dd351c954c097a28ddf752edeb6b exit with error code 1 if command
fails
+ 92ba9bb9c5594223083029cc8676b5c20d826c33 raise error in blended data if
profile or system not found
Both look good. I'm applying them now.
WebUI redundant code:
+ efbc6519b34e9b9c95a9298d68fbf340b0a82c1d remove duplicate code
I don't know much about the WUI, if someone else can verify that this
works I'll merge it.
I'll wait for a response on the balance of these before merging up.
--
Scott Henson
Red Hat CIS Operator
WVU Alum BSAE/BSME