Changing the netboot to enable does not work anymore without running the sync command. The reason is that the dhcp template does not generate the next_server and filename lines for a host when netboot is disabled.
My proposal is to split the code single sync.run() into multiple methods .run_dhcp(), .run_dns() and .run_files(). The .run() will then call all the specific methods.
Peter
This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.
Vreman, Peter - Acision wrote:
Changing the netboot to enable does not work anymore without running the sync command. The reason is that the dhcp template does not generate the next_server and filename lines for a host when netboot is disabled.
This is definitely a bug, it should always generate them so we can use PXE to control whether they boot locally. You're saying this problem is devel only?
My proposal is to split the code single sync.run() into multiple methods .run_dhcp(), .run_dns() and .run_files(). The .run() will then call all the specific methods.
The fix is to terminate the bug with extreme prejudice, rather than to modularize sync. That can be done, but code "refactoring" is not the best way to fix a bug, it is however a great way to introduce more of them :)
Peter
This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.
cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Changing the netboot to enable does not work anymore without running the sync command. The reason is that the dhcp template does not generate the next_server and filename lines for a host when netboot is disabled.
This is definitely a bug, it should always generate them so we can use PXE to control whether they boot locally. You're saying this problem is devel only?
This bug is also in master. Also the dhcp template generation without dns_names is broken in master.
Sorry for the proposal confusion. I could better have written that creating a dhcp only sync method and calling that after a netboot change.
Peter
This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.
Vreman, Peter - Acision wrote:
Changing the netboot to enable does not work anymore without running the sync command. The reason is that the dhcp template does not generate the next_server and filename lines for a host when netboot is disabled.
This is definitely a bug, it should always generate them so we can use PXE to control whether they boot locally. You're saying this problem is devel only?
This bug is also in master. Also the dhcp template generation without dns_names is broken in master.
Define what this means?
Sorry for the proposal confusion. I could better have written that creating a dhcp only sync method and calling that after a netboot change.
Nah, we just need to make sure there is no logic to hide systems that are netboot-disabled.
That flag only pertains to PXE, not whether they can get an IP. I assume someone made the mistake and that went by undetected.
Changing the netboot to enable does not work anymore without running the sync command. The reason is that the dhcp template does not generate the next_server and filename lines for a host when netboot is disabled.
This is definitely a bug, it should always generate them so we can use PXE to control whether they boot locally. You're saying this problem is devel only?
This bug is also in master. Also the dhcp template generation without
dns_names is broken in master.
Define what this means?
The dns_name is used as key in the blended_system cache. With an empty name the same cached system record (gateway/netboot_enabled/hostname) values are used.
Also the blended_system cache is not needed at all because the blended_system can already be generated in the system-loop instead of the interface-loop. See my other patch that simplifies the code in manage_isc.py.
Sorry for the proposal confusion. I could better have written that
creating a dhcp only sync method and calling that after a netboot change.
Nah, we just need to make sure there is no logic to hide systems that are netboot-disabled.
That flag only pertains to PXE, not whether they can get an IP. I assume someone made the mistake and that went by undetected.
It was done by design because the netboot_enabled is added to the dictioanary also in code. The fix is simple. Remove the netboot_enabled if statement in dhcp.template
Peter
This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.
Vreman, Peter - Acision wrote:
Changing the netboot to enable does not work anymore without running the sync command. The reason is that the dhcp template does not generate the next_server and filename lines for a host when netboot is disabled.
This is definitely a bug, it should always generate them so we can use PXE to control whether they boot locally. You're saying this problem is devel only?
This bug is also in master. Also the dhcp template generation without
dns_names is broken in master.
Define what this means?
The dns_name is used as key in the blended_system cache. With an empty name the same cached system record (gateway/netboot_enabled/hostname) values are used.
Also the blended_system cache is not needed at all because the blended_system can already be generated in the system-loop instead of the interface-loop. See my other patch that simplifies the code in manage_isc.py.
Link?
Sorry for the proposal confusion. I could better have written that
creating a dhcp only sync method and calling that after a netboot change.
Nah, we just need to make sure there is no logic to hide systems that are netboot-disabled.
That flag only pertains to PXE, not whether they can get an IP. I assume someone made the mistake and that went by undetected.
It was done by design because the netboot_enabled is added to the dictioanary also in code. The fix is simple. Remove the netboot_enabled if statement in dhcp.template
Indeed.
Peter
This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.
cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Define what this means?
The dns_name is used as key in the blended_system cache. With an empty
name the same cached system record (gateway/netboot_enabled/hostname) values are used.
Also the blended_system cache is not needed at all because the
blended_system can already be generated in the system-loop instead of the interface-loop. See my other patch that simplifies the code in manage_isc.py.
Link?
See the message "[PATCH] fix dhcp template generation"
Peter
This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.
Vreman, Peter - Acision wrote:
Changing the netboot to enable does not work anymore without running the sync command. The reason is that the dhcp template does not generate the next_server and filename lines for a host when netboot is disabled.
My proposal is to split the code single sync.run() into multiple methods .run_dhcp(), .run_dns() and .run_files(). The .run() will then call all the specific methods.
Peter
This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.
cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
I've removed the logic from the template.
Thanks!
cobbler-devel@lists.fedorahosted.org