James Cammarata wrote:
Really? I post the url to the patch on my account, and if you click
on it it shows the diffs in a nice highlighted format.
That's a good bit harder, in my opinion, than having the patch in the
email where I can read it and reply to it. To each his own, of
course.
Yeah, but all the top maintainers all push and pull from each
other's git repos too for the exact same reason - it's easier than
manually applying text patches, especially when you have to deal
with crappy mail clients reformatting things or dozens of .patch
files.
For the most part, I think teaching people to not use broken mail
clients is a better path. But I've been known to be stubborn and
idealistic. ;)
It's been tradition for years that if you are making major
feature
changes that you have a github account, or some other public git
repo that can be pulled from. If you send in one patch a year and
hate github, no problem. But if you're rewriting large chunks of
code, I'd much prefer pulling from a repo than dealing with 20+ text
files.
Sure, having a git repo to pull from is handy for projects you work on
a lot. I still don't use github for this, but that's just me. Also,
whether you're a maintainer or not, if you manually save and apply
patch files this way, you're missing the huge savings that git am
provides. It is meant to parse mailbox files, so you simply save/copy
the messages you want to a mailbox and feed that to git am.
I do tend to send more small patches to numerous projects and I am
often burned by this "use github" mentality. If I had to set up a
public repo for every project I wanted to send a few patches to, I'd
simply send less patches because the effort isn't worth it.
Sadly, I've often sent patches upstream and had them applied manually
without the proper commit message or attribution (which I care about
more so that I am blamed for bad code than I do about credit for good
code).
Apologies for ranting a bit. It's just a pet peeve of mine.
--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL:
www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
If everything seems to be going well, you have obviously overlooked
something.