This is a little messy, but it's kind of unavoidable with the way validateks was working before (calling an outside application to do the validation).
I also noticed a way to considerably speed up validation time, which is to cache the kickstart paths in an array and to check that before doing too much work. After all, why validate the same kickstart file over and over again?
On Wed, 13 May 2009 14:28:15 -0500, James Cammarata jimi@sngx.net wrote:
This is a little messy, but it's kind of unavoidable with the way validateks was working before (calling an outside application to do the validation).
I also noticed a way to considerably speed up validation time, which is
to
cache the kickstart paths in an array and to check that before doing too much work. After all, why validate the same kickstart file over and over again?
One downside I forgot to mention about this: it will flag every kickstart out there as a potential problem, due to the fact that the hashed root password has $'s in it (which cheetah was silently ignoring before).
We need to wrap that line in a #raw block in the future.
On Wed, 13 May 2009 14:28:15 -0500, James Cammarata jimi@sngx.net wrote:
This is a little messy, but it's kind of unavoidable with the way validateks was working before (calling an outside application to do the validation).
I also noticed a way to considerably speed up validation time, which is
to
cache the kickstart paths in an array and to check that before doing too much work. After all, why validate the same kickstart file over and over again?
Pushed this up to my github now, so you can pull it from there.
commit e2b876f0fb480a548b47f4f5ccb20a3f71bfdb07 Author: James Cammarata jimi@sngx.net Date: Wed May 13 18:34:14 2009 -0500
Added ability to list errors generated by cheetah during templating Added list of cheetah template errors generated to validateks output Added caching to url checking to speed up validation process
cobbler-devel@lists.fedorahosted.org