The --no-fail option to "cobbler reposync" has not been respected since the 2.0 conversion of the CLI to use the remote API. Fix this by checking for the option in CobblerXMLRPCInterface.background_reposync. Default behavior (viz. nofail=True when repositories are specified, nofail=False otherwise) is maintained. --- This patch (based on stable) can also be pulled from:
cobbler-devel@lists.fedorahosted.org fix-reposync-no-fail
cobbler/remote.py | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/cobbler/remote.py b/cobbler/remote.py index 756e9ec..05f5462 100644 --- a/cobbler/remote.py +++ b/cobbler/remote.py @@ -233,14 +233,15 @@ class CobblerXMLRPCInterface: only = options.get("only", None) if only is not None: repos = [ only ] + nofail = options.get("nofail", len(repos) > 0)
if len(repos) > 0: for name in repos: self.remote.api.reposync(tries=self.options.get("tries", - 3), name=name, nofail=True, logger=self.logger) + 3), name=name, nofail=nofail, logger=self.logger) else: self.remote.api.reposync(tries=self.options.get("tries",3), - name=None, nofail=False, logger=self.logger) + name=None, nofail=nofail, logger=self.logger) return True return self.__start_task(runner, token, "reposync", "Reposync", options)
On 7 Mar 2011, at 10:39 PM, Ian Ward Comfort wrote:
This patch (based on stable) can also be pulled from:
cobbler-devel@lists.fedorahosted.org fix-reposync-no-fail
Whoops; that should be
git://github.com/icomfort/cobbler.git fix-reposync-no-fail
of course.
On Mon, 7 Mar 2011 22:40:46 -0800, Ian Ward Comfort icomfort@stanford.edu wrote:
On 7 Mar 2011, at 10:39 PM, Ian Ward Comfort wrote:
This patch (based on stable) can also be pulled from:
cobbler-devel@lists.fedorahosted.org fix-reposync-no-fail
Whoops; that should be
git://github.com/icomfort/cobbler.git fix-reposync-no-fail
of course.
Merged, Thanks!
cobbler-devel@lists.fedorahosted.org