From: Garrett Holmstrom garrett.holmstrom@gmail.com
To: cobbler development list cobbler-devel@lists.fedorahosted.org Sent: Sat, November 14, 2009 7:38:07 AM Subject: Re: [PATCH] Logging and cli error patches for master
From: "Jeff Schroeder" Date: Friday, November 13, 2009 10:23 PM To: "cobbler development list" Subject: Re: [PATCH] Logging and cli error patches for master
I know that keeping koan small and self contained was very important for Michael when he wrote it. He got it running fine on rhel2.1 to help migrate those installs over to virtual machines.
Not that I personally mind, but it would be sad to see that work thrown out for a seemingly innocent patch.
As far as 2.1 goes, the impression I got from Michael from our IRC conversations was that the most important thing about koan on 2.1 is that the "replace-self" code path works; anything else that works is convenient, but not critical. He also briefly explains this near the top of app.py.
Aside: Support for Python 1.5 is one reason Trac #523 existed in the first place - modules that are normally unavailable in or incompatible with 1.5.
Actually, not even Python 2.3 has some of these modules.
It has been some time since I've looked at much of the code, but if koan currently uses only a small portion of the code that cobbler uses then I could understand avoiding this in the interest of being "small and self-contained." I don't see pulling in a tiny dependency as a problem, however. On the other hand, one downside is that a machine with both cobbler and koan installed will always have to have the same versions of each installed since they share a common library (python-libcobbler?). (I personally don't mind this.) Alternatively, we could start tracking library versions separately and updating cobbler's and koan's rpm requires accordingly.
That's an interesting downside, although I wonder how many people want to run (radically) different versions of cobbler and koan on the same machine. What I'm thinking of is that it shouldn't be a problem using, let's say koan 2.0.4 with cobbler 2.0.7 or even koan 2.1 with cobbler 2.2 because the common part doesn't seem to be very complicated.
Regards, Cristian