On 10/02/2009 10:44 AM, Cristian Ciupitu wrote:
----- Original Message ----
From: Cristian Ciupitucristian.ciupitu@yahoo.com To: cobbler development listcobbler-devel@lists.fedorahosted.org Sent: Friday, October 2, 2009 2:02:59 AM Subject: Re: [PATCH] sessions directory should be moved from /usr/share/cobbler/web to /var (#499)
Regarding the ultra-new action_check.py, I see that you're checking for httpd_sys_content_t, but as I've mentioned earlier the sessions directory uses by default another context, so for what context should I check: httpd_sys_content_t or var_lib_t?
One more thing regarding the SELinux context. Besides httpd_sys_content_t there is also httpd_sys_content_rw_t. The man page says:
The following file contexts types are defined for httpd:
- Set files with httpd_sys_content_t if you want httpd_sys_script_exec_t scripts and the daemon to read the file, and disallow other non sys scripts from access.
- Set files with httpd_sys_content_rw_t if you want httpd_sys_script_exec_t scripts and the daemon to *read/write* the data, and disallow other non sys scripts from access.
Anyway, I've modified the directories from "action_check.py". See git://github.com/ciupicri/cobbler.git branch bugfix499. I'm still a git newbie so sorry for all these git related changes.
Thank you, Cristian
Taking a look ... I need to do various SELinux related testing so I'll post up with what the situation is later today as to whether we'll go with this or also need additional changes.
As for git, keeping different fixes on different branches rather than requiring cherry-picking is a very good way to do it. It is better than assuming all patches will get applied in sequence.
--Michael