Thanks for all the patches, Peter. I have applied all I could except
the
filter one, which I explained why below. I'm definitely interested in
search upgrades, but am not sure we want a "filter" object.
I'm not saying that's final, it's just that I first would have to see
what some email/text demo of what a filter object would look like and
how some one would use it. Most likely I would like to see simpler
ways of implementing saved search, even if it's something that simply
saves them in a datastructure and not using the cobbler object system,
that would be ok... perhaps even Bookmarklets?
All of these are applied to the devel branch when I say "Applied". If
there are any fixes to the 1.6.2 search (i.e for bugs, those go against
master).
Thanks for applying the patches.
The commit 4e155e67b6cc5c8b756f0df59b21c9e14c400b67 (>
0009-rename-with-same-name-does-nothing-instead-of-deleti.patch) is a bug fix that should
also be in master.
0004-filter-objects-added.patch.gz
Not applied. In my previous email, I indicated we strongly didn't want
to introduce the concept of a new cobbler "noun" for something like
saved search results. A better way to do this would be to just have a
way to save search parameters in the settings file and let them show up
on the search page, perhaps as hyperlinks. We want to reserve cobbler
"nouns" for data that cobbler is trying to model. The main reason for
all this is that new object types require a tremendous amount of code
(that we eventually want to clean up), and we want to keep things as
simple as possible.
To show you what my goal was to create I have attached two screenshots of the patch. The
saved filters will allow quick filtering using a dropdown box on the list screen.
The filter object is a hash with the following keys:
- name
- what (distro/system/profile/...)
- keys hash
- (not implemented yet) matching type ALL or ANY
I still used the cobbler "noun" in this patch because that part was already
finished and working. Refactoring of the "noun" to a custom array of hashes can
be done. But how shall the serialization to disk be implemented if the "noun"
part can't be reused?
Peter
This e-mail and any attachment is for authorised use by the intended recipient(s) only. It
may contain proprietary material, confidential information and/or be subject to legal
privilege. It should not be copied, disclosed to, retained or used by, any other party. If
you are not an intended recipient then please promptly delete this e-mail and any
attachment and all copies and inform the sender. Thank you.