Vreman, Peter - Acision wrote:
Hi Michael,
Please find attached the webui_search.diff patch as a regular diff.
The git-format-patch doesn’t work for me.
Features
- paginate search results
- quickfilter
- allow ~ to negate a compare in search
- minor log improvements
Todos
- Delete filters
- Modify filters (Load filter does not work yet)
- Allow filter names per collection only. I guess I Need to combine
the filter.name with the filter.what field somehow.
Please feel free to commit the current work if you like it.
Regards,
Peter
This e-mail and any attachment is for authorised use by the intended
recipient(s) only. It may contain proprietary material, confidential
information and/or be subject to legal privilege. It should not be
copied, disclosed to, retained or used by, any other party. If you are
not an intended recipient then please promptly delete this e-mail and
any attachment and all copies and inform the sender. Thank you.
Thanks for all the patches, Peter. I have applied all I could except the
filter one, which I explained why below. I'm definitely interested in
search upgrades, but am not sure we want a "filter" object.
I'm not saying that's final, it's just that I first would have to see
what some email/text demo of what a filter object would look like and
how some one would use it. Most likely I would like to see simpler
ways of implementing saved search, even if it's something that simply
saves them in a datastructure and not using the cobbler object system,
that would be ok... perhaps even Bookmarklets?
All of these are applied to the devel branch when I say "Applied". If
there are any fixes to the 1.6.2 search (i.e for bugs, those go against
master).
0001-allow-to-negate-a-compare-in-search.patch
Applied.
0002-log-name-and-prefix-REMOTE-for-remote-api.patch
Applied. The code to add the prefix "REMOTE" is probably not neccessary
because we log cobblerd actions to "cobblerd.log" presently, though I'd
like to eventually fix that to just have one API log in the future. So
this is good.
0003-remove-trailing-newline.patch
Applied.
0004-filter-objects-added.patch.gz
Not applied. In my previous email, I indicated we strongly didn't want
to introduce the concept of a new cobbler "noun" for something like
saved search results. A better way to do this would be to just have a
way to save search parameters in the settings file and let them show up
on the search page, perhaps as hyperlinks. We want to reserve cobbler
"nouns" for data that cobbler is trying to model. The main reason for
all this is that new object types require a tremendous amount of code
(that we eventually want to clean up), and we want to keep things as
simple as possible.
0005-check-for-None-before-checking-for.patch
Applied.
0006-save-dhcp.template-in-devinstall.patch
Applied.
0007-use-field-names-with-underscores.patch
Applied.
0008-use-redirects-to-return-to-list-page-after-operation.patch
This patch does not apply, probably because it requires some of patch
0004, so I could not successfully apply this.
0009-rename-with-same-name-does-nothing-instead-of-deleti.patch
Applied