On Wed, 9 Mar 2011 15:09:50 +0100, Uwe Gansert ug@suse.de wrote:
on Monday 07 March 2011 Scott Henson wrote:
Can you put a repo up on github? It is much easier to exchange patches that way. Thanks.
okay, I did so: https://github.com/ugansert/Cobbler
Nice, it all looks good except the following bit.
diff --git a/cobbler/remote.py b/cobbler/remote.py index 0e6b8dd..a692670 100644 --- a/cobbler/remote.py +++ b/cobbler/remote.py @@ -92,7 +92,7 @@ class CobblerThread(Thread): try: rc = self._run(self) self.remote._set_task_state(self,self.event_id,EVENT_COMPLETE) - self.on_done() + self.on_done return rc except: utils.log_exc(self.logger)
That should be calling the method. I believe we just merged a patch to fix that recently.