Vreman, Peter - Acision wrote:
There is a difference in the internal and remote api.
The internal api has find_system to retrieve a single or multiple items with an optional filter.
The remote api has a dedicated get_system to retrieve a single item
Can this be changed to:
Api.find_systems(matchtype,**kvargs) returns a list
Api.get_system(name) returns a item
Api.get_systems returns a list
Remote.find_systems(matchtype,page,results_per_page,**kvargs) returns a list
Remote.get_system(name) returns a item
Remote.get_systems() returns a list
This makes it more consistent and transparent. The remote functions will become simple wrappers. Eventually the paginate function can also be merged into the Api instead of Remote.
We can do what we want with remote as long as the previous calling syntaxes still work.
I think before you talked about implementing most of the remote functions via a wrapper to find, which I agree with.
The important thing is to not break API calling signatures of any of the local or remote methods.
Any new arguments should have default values so those new arguments are optional.
--Michael