I have the following list of patches for master available at http://github.com/pvreman/cobbler/commits/master/.
Koan:
- afda8a88249ed3a124651a25fc52e9f78d1ab414 update
string_to_hash and hash_to_string from cobblerd to support multiple
kernel
options with the same name
In hash_to_string:
- if type(hash) != dict:
return hash
If string values are legacy why not test against str, so that we could use dictionary like objects in future?
- for key in hash:
value = hash[key]
Why not for k, v in hash.items()?
Also, you could make buffer a list of strings ("key=val") and then join them by doing " ".join(buffer).
I copied only the code from cobbler/utils.py. This optimization shall then be applied to both koan and cobbler. Or maybe even better make koan and cobbler share the same module.
CLI error handling:
- e9d0cf90df35dd351c954c097a28ddf752edeb6b exit with error
code 1 if command fails
Unrelated to your code: I've noticed that if check fails it will exit with a 411 error code. Perhaps this would be a good time to get rid of these magic numbers?
This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.