Available via my github:
commit 6a5032061d593d61a9aa81162be77fa75fc60f9a Author: James Cammarata jimi@sngx.net Date: Wed Feb 16 18:28:23 2011 -0600
Modification to generic_edit template so that the name field is not a text box when editing.
If this value is changed during a normal edit, an error is generated during save indicating the object no longer exists, which is not exactly user-friendly.
On Wed, 16 Feb 2011 18:29:45 -0600, James Cammarata jimi@sngx.net wrote:
Available via my github:
commit 6a5032061d593d61a9aa81162be77fa75fc60f9a Author: James Cammarata jimi@sngx.net Date: Wed Feb 16 18:28:23 2011 -0600
Modification to generic_edit template so that the name field is
not a text box when editing.
If this value is changed during a normal edit, an error is
generated during save indicating the object no longer exists, which is not exactly user-friendly.
Applied. Thanks.
On Tue, Feb 22, 2011 at 10:53 AM, Scott Henson shenson@redhat.com wrote:
On Wed, 16 Feb 2011 18:29:45 -0600, James Cammarata jimi@sngx.net wrote:
Available via my github:
commit 6a5032061d593d61a9aa81162be77fa75fc60f9a Author: James Cammarata jimi@sngx.net Date: Wed Feb 16 18:28:23 2011 -0600
Modification to generic_edit template so that the name field is not a text box when editing.
If this value is changed during a normal edit, an error is generated during save indicating the object no longer exists, which is not exactly user-friendly.
Applied. Thanks.
-- Scott Henson Red Hat CIS Operator WVU Alum BSAE/BSME
cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Can you take a look at the git master cobbler instance and look at the management classes for a host with no classes added. Something is not right here. You can't add management classes right now through the web interface. What do you see this looking like in the end? Would it be a drop down with all the management classes and be able to edit them in the drop down? Right now it's pretty unusable.
On Thu, Feb 24, 2011 at 12:35 PM, Jonathan Sabo jsabo@criminal.org wrote:
On Tue, Feb 22, 2011 at 10:53 AM, Scott Henson shenson@redhat.com wrote:
On Wed, 16 Feb 2011 18:29:45 -0600, James Cammarata jimi@sngx.net wrote:
Available via my github:
commit 6a5032061d593d61a9aa81162be77fa75fc60f9a Author: James Cammarata jimi@sngx.net Date: Wed Feb 16 18:28:23 2011 -0600
Modification to generic_edit template so that the name field is not a text box when editing.
If this value is changed during a normal edit, an error is generated during save indicating the object no longer exists, which is not exactly user-friendly.
Applied. Thanks.
-- Scott Henson Red Hat CIS Operator WVU Alum BSAE/BSME
cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Can you take a look at the git master cobbler instance and look at the management classes for a host with no classes added. Something is not right here. You can't add management classes right now through the web interface. What do you see this looking like in the end? Would it be a drop down with all the management classes and be able to edit them in the drop down? Right now it's pretty unusable.
Ahhh.... nevermind. I didn't see the create new management classes stuff.
Yeah its pretty different :) On Feb 24, 2011 1:40 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 12:35 PM, Jonathan Sabo jsabo@criminal.org
wrote:
On Tue, Feb 22, 2011 at 10:53 AM, Scott Henson shenson@redhat.com
wrote:
On Wed, 16 Feb 2011 18:29:45 -0600, James Cammarata jimi@sngx.net
wrote:
Available via my github:
commit 6a5032061d593d61a9aa81162be77fa75fc60f9a Author: James Cammarata jimi@sngx.net Date: Wed Feb 16 18:28:23 2011 -0600
Modification to generic_edit template so that the name field is
not a text box when editing.
If this value is changed during a normal edit, an error is
generated during save indicating the object no longer exists, which is not exactly
user-friendly.
Applied. Thanks.
-- Scott Henson Red Hat CIS Operator WVU Alum BSAE/BSME
cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Can you take a look at the git master cobbler instance and look at the management classes for a host with no classes added. Something is not right here. You can't add management classes right now through the web interface. What do you see this looking like in the end? Would it be a drop down with all the management classes and be able to edit them in the drop down? Right now it's pretty unusable.
Ahhh.... nevermind. I didn't see the create new management classes stuff.
On Thu, Feb 24, 2011 at 2:55 PM, James Cammarata jimi@sngx.net wrote:
Yeah its pretty different :)
On Feb 24, 2011 1:40 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 12:35 PM, Jonathan Sabo jsabo@criminal.org wrote:
On Tue, Feb 22, 2011 at 10:53 AM, Scott Henson shenson@redhat.com wrote:
On Wed, 16 Feb 2011 18:29:45 -0600, James Cammarata jimi@sngx.net wrote:
Available via my github:
commit 6a5032061d593d61a9aa81162be77fa75fc60f9a Author: James Cammarata jimi@sngx.net Date: Wed Feb 16 18:28:23 2011 -0600
Modification to generic_edit template so that the name field is not a text box when editing.
If this value is changed during a normal edit, an error is generated during save indicating the object no longer exists, which is not exactly user-friendly.
Applied. Thanks.
-- Scott Henson Red Hat CIS Operator WVU Alum BSAE/BSME
cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Can you take a look at the git master cobbler instance and look at the management classes for a host with no classes added. Something is not right here. You can't add management classes right now through the web interface. What do you see this looking like in the end? Would it be a drop down with all the management classes and be able to edit them in the drop down? Right now it's pretty unusable.
Ahhh.... nevermind. I didn't see the create new management classes stuff.
I just added some management classes and they don't seem to show up under the profiles drop downs. How is that intended to work?
I can't reproduce, it works as expected on my system. Are you seeing any JavaScript errors? I've only tested on Firefox but the code was based on the interface JavaScript. On Feb 24, 2011 2:01 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 2:55 PM, James Cammarata jimi@sngx.net wrote:
Yeah its pretty different :)
On Feb 24, 2011 1:40 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 12:35 PM, Jonathan Sabo jsabo@criminal.org wrote:
On Tue, Feb 22, 2011 at 10:53 AM, Scott Henson shenson@redhat.com wrote:
On Wed, 16 Feb 2011 18:29:45 -0600, James Cammarata jimi@sngx.net wrote:
Available via my github:
commit 6a5032061d593d61a9aa81162be77fa75fc60f9a Author: James Cammarata jimi@sngx.net Date: Wed Feb 16 18:28:23 2011 -0600
Modification to generic_edit template so that the name field is
not a text box when editing.
If this value is changed during a normal edit, an error is
generated during save indicating the object no longer exists, which is not exactly user-friendly.
Applied. Thanks.
-- Scott Henson Red Hat CIS Operator WVU Alum BSAE/BSME
cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Can you take a look at the git master cobbler instance and look at the management classes for a host with no classes added. Something is not right here. You can't add management classes right now through the web interface. What do you see this looking like in the end? Would it be a drop down with all the management classes and be able to edit them in the drop down? Right now it's pretty unusable.
Ahhh.... nevermind. I didn't see the create new management classes
stuff.
I just added some management classes and they don't seem to show up under the profiles drop downs. How is that intended to work?
On Thu, Feb 24, 2011 at 3:08 PM, James Cammarata jimi@sngx.net wrote:
I can't reproduce, it works as expected on my system. Are you seeing any JavaScript errors? I've only tested on Firefox but the code was based on the interface JavaScript.
On Feb 24, 2011 2:01 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 2:55 PM, James Cammarata jimi@sngx.net wrote:
Yeah its pretty different :)
On Feb 24, 2011 1:40 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 12:35 PM, Jonathan Sabo jsabo@criminal.org wrote:
On Tue, Feb 22, 2011 at 10:53 AM, Scott Henson shenson@redhat.com wrote:
On Wed, 16 Feb 2011 18:29:45 -0600, James Cammarata jimi@sngx.net wrote: > Available via my github: > > commit 6a5032061d593d61a9aa81162be77fa75fc60f9a > Author: James Cammarata jimi@sngx.net > Date: Wed Feb 16 18:28:23 2011 -0600 > > Modification to generic_edit template so that the name field is > not a text box when editing. > > If this value is changed during a normal edit, an error is > generated during save > indicating the object no longer exists, which is not exactly > user-friendly.
Applied. Thanks.
-- Scott Henson Red Hat CIS Operator WVU Alum BSAE/BSME
cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Can you take a look at the git master cobbler instance and look at the management classes for a host with no classes added. Something is not right here. You can't add management classes right now through the web interface. What do you see this looking like in the end? Would it be a drop down with all the management classes and be able to edit them in the drop down? Right now it's pretty unusable.
Ahhh.... nevermind. I didn't see the create new management classes stuff.
I just added some management classes and they don't seem to show up under the profiles drop downs. How is that intended to work?
The only errors I see are:
Warning: Error in parsing value for 'overflow'. Declaration dropped. Source File: http://192.168.69.3/cobbler_webui_content/style.css Line: 23
and
Error: on_form_submit is not defined Source File: http://192.168.69.3/cobbler_web/mgmtclass/edit/001-base Line: 1
I'm adding a management class through the field stuff and I'm expecting that to be available to be chosen through distros, profiles, and systems and that's not happening. I'm using the git master as of today.
If you view the source code, do you see the function populate_mgmt_classes()? If so, do you see the lines where new options are being added?
var new_option = new Option("Foo","Foo") On Feb 24, 2011 2:26 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 3:08 PM, James Cammarata jimi@sngx.net wrote:
I can't reproduce, it works as expected on my system. Are you seeing any JavaScript errors? I've only tested on Firefox but the code was based on
the
interface JavaScript.
On Feb 24, 2011 2:01 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 2:55 PM, James Cammarata jimi@sngx.net wrote:
Yeah its pretty different :)
On Feb 24, 2011 1:40 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 12:35 PM, Jonathan Sabo jsabo@criminal.org wrote:
On Tue, Feb 22, 2011 at 10:53 AM, Scott Henson shenson@redhat.com wrote: > On Wed, 16 Feb 2011 18:29:45 -0600, James Cammarata jimi@sngx.net > wrote: >> Available via my github: >> >> commit 6a5032061d593d61a9aa81162be77fa75fc60f9a >> Author: James Cammarata jimi@sngx.net >> Date: Wed Feb 16 18:28:23 2011 -0600 >> >> Modification to generic_edit template so that the name field is >> not a text box when editing. >> >> If this value is changed during a normal edit, an error is >> generated during save >> indicating the object no longer exists, which is not exactly >> user-friendly. > > Applied. Thanks. > > -- > Scott Henson > Red Hat CIS Operator > WVU Alum BSAE/BSME > > _______________________________________________ > cobbler-devel mailing list > cobbler-devel@lists.fedorahosted.org > https://fedorahosted.org/mailman/listinfo/cobbler-devel > >
Can you take a look at the git master cobbler instance and look at
the
management classes for a host with no classes added. Something is
not
right here. You can't add management classes right now through the web interface. What do you see this looking like in the end? Would it be a drop down with all the management classes and be able to edit them in the drop down? Right now it's pretty unusable.
Ahhh.... nevermind. I didn't see the create new management classes stuff.
I just added some management classes and they don't seem to show up under the profiles drop downs. How is that intended to work?
The only errors I see are:
Warning: Error in parsing value for 'overflow'. Declaration dropped. Source File: http://192.168.69.3/cobbler_webui_content/style.css Line: 23
and
Error: on_form_submit is not defined Source File: http://192.168.69.3/cobbler_web/mgmtclass/edit/001-base Line: 1
I'm adding a management class through the field stuff and I'm expecting that to be available to be chosen through distros, profiles, and systems and that's not happening. I'm using the git master as of today.
On Thu, Feb 24, 2011 at 3:46 PM, James Cammarata jimi@sngx.net wrote:
If you view the source code, do you see the function populate_mgmt_classes()? If so, do you see the lines where new options are being added?
var new_option = new Option("Foo","Foo")
On Feb 24, 2011 2:26 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 3:08 PM, James Cammarata jimi@sngx.net wrote:
I can't reproduce, it works as expected on my system. Are you seeing any JavaScript errors? I've only tested on Firefox but the code was based on the interface JavaScript.
On Feb 24, 2011 2:01 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 2:55 PM, James Cammarata jimi@sngx.net wrote:
Yeah its pretty different :)
On Feb 24, 2011 1:40 PM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 12:35 PM, Jonathan Sabo jsabo@criminal.org wrote: > On Tue, Feb 22, 2011 at 10:53 AM, Scott Henson shenson@redhat.com > wrote: >> On Wed, 16 Feb 2011 18:29:45 -0600, James Cammarata jimi@sngx.net >> wrote: >>> Available via my github: >>> >>> commit 6a5032061d593d61a9aa81162be77fa75fc60f9a >>> Author: James Cammarata jimi@sngx.net >>> Date: Wed Feb 16 18:28:23 2011 -0600 >>> >>> Modification to generic_edit template so that the name field is >>> not a text box when editing. >>> >>> If this value is changed during a normal edit, an error is >>> generated during save >>> indicating the object no longer exists, which is not exactly >>> user-friendly. >> >> Applied. Thanks. >> >> -- >> Scott Henson >> Red Hat CIS Operator >> WVU Alum BSAE/BSME >> >> _______________________________________________ >> cobbler-devel mailing list >> cobbler-devel@lists.fedorahosted.org >> https://fedorahosted.org/mailman/listinfo/cobbler-devel >> >> > > Can you take a look at the git master cobbler instance and look at > the > management classes for a host with no classes added. Something is > not > right here. You can't add management classes right now through the > web interface. What do you see this looking like in the end? Would > it be a drop down with all the management classes and be able to edit > them in the drop down? Right now it's pretty unusable. >
Ahhh.... nevermind. I didn't see the create new management classes stuff.
I just added some management classes and they don't seem to show up under the profiles drop downs. How is that intended to work?
The only errors I see are:
Warning: Error in parsing value for 'overflow'. Declaration dropped. Source File: http://192.168.69.3/cobbler_webui_content/style.css Line: 23
and
Error: on_form_submit is not defined Source File: http://192.168.69.3/cobbler_web/mgmtclass/edit/001-base Line: 1
I'm adding a management class through the field stuff and I'm expecting that to be available to be chosen through distros, profiles, and systems and that's not happening. I'm using the git master as of today.
cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
(04:01 PM) (jsabo@frostedflakes) (0/pts/3) (~/Source/cobbler)
$ grep -r populate_mgmt_classes * web/cobbler_web/templates/generic_edit.tmpl: populate_mgmt_classes();
Where is that defined? Are we missing that in the git master perhaps?
(04:01 PM) (jsabo@frostedflakes) (0/pts/3) (~/Source/cobbler)
$ grep -r populate_mgmt_classes * web/cobbler_web/templates/generic_edit.tmpl: populate_mgmt_classes();
Where is that defined? Are we missing that in the git master perhaps?
I see it in my commit tree, and I just did a git pull. The function is in the template web/cobbler_web/templates/generic_edit.tmpl. Can you verify you see it there?
The javascript function looks like this on my system:
function populate_mgmt_classes() { var mgmt_classes = document.getElementById("mgmtclasses");
var new_option = new Option("test1","test1") mgmt_classes.options.add(new_option);
var new_option = new Option("test2","test2") mgmt_classes.options.add(new_option);
var new_option = new Option("test3","test3") mgmt_classes.options.add(new_option);
mgmt_classes.selectedIndex = 0 }
It looks the same for distros/profiles/systems. The commit that included this was:
commit 03834b92314a9f8df8a5d433c84c98ed2e6f573f
On Thu, Feb 24, 2011 at 6:48 PM, James Cammarata jimi@sngx.net wrote:
(04:01 PM) (jsabo@frostedflakes) (0/pts/3) (~/Source/cobbler)
$ grep -r populate_mgmt_classes * web/cobbler_web/templates/generic_edit.tmpl: populate_mgmt_classes();
Where is that defined? Are we missing that in the git master perhaps?
I see it in my commit tree, and I just did a git pull. The function is in the template web/cobbler_web/templates/generic_edit.tmpl. Can you verify you see it there?
The javascript function looks like this on my system:
function populate_mgmt_classes() { var mgmt_classes = document.getElementById("mgmtclasses");
var new_option = new Option("test1","test1") mgmt_classes.options.add(new_option);
var new_option = new Option("test2","test2") mgmt_classes.options.add(new_option);
var new_option = new Option("test3","test3") mgmt_classes.options.add(new_option);
mgmt_classes.selectedIndex = 0 }
It looks the same for distros/profiles/systems. The commit that included this was:
commit 03834b92314a9f8df8a5d433c84c98ed2e6f573f
(09:30 PM) (jsabo@frostedflakes) (0/pts/7) (~)
$ git clone http://git.fedorahosted.org/git/cobbler Initialized empty Git repository in /home/jsabo/cobbler/.git/
(09:32 PM) (jsabo@frostedflakes) (0/pts/7) (~)
$ cd cobbler/
(10:03 PM) (jsabo@frostedflakes) (0/pts/7) (~/cobbler)
$ git log | grep 03834b92314a9f8df8a5d433c84c98ed2e6f573f
(10:03 PM) (jsabo@frostedflakes) (0/pts/7) (~/cobbler)
$ grep -r populate_mgmt * web/cobbler_web/templates/generic_edit.tmpl: populate_mgmt_classes();
It's not it the git master.
(09:30 PM) (jsabo@frostedflakes) (0/pts/7) (~)
$ git clone http://git.fedorahosted.org/git/cobbler Initialized empty Git repository in /home/jsabo/cobbler/.git/
(09:32 PM) (jsabo@frostedflakes) (0/pts/7) (~)
$ cd cobbler/
(10:03 PM) (jsabo@frostedflakes) (0/pts/7) (~/cobbler)
$ git log | grep 03834b92314a9f8df8a5d433c84c98ed2e6f573f
(10:03 PM) (jsabo@frostedflakes) (0/pts/7) (~/cobbler)
$ grep -r populate_mgmt * web/cobbler_web/templates/generic_edit.tmpl: populate_mgmt_classes();
It's not it the git master.
Confirmed, that patch was missed.
On Thu, Feb 24, 2011 at 10:16 PM, James Cammarata jimi@sngx.net wrote:
(09:30 PM) (jsabo@frostedflakes) (0/pts/7) (~)
$ git clone http://git.fedorahosted.org/git/cobbler Initialized empty Git repository in /home/jsabo/cobbler/.git/
(09:32 PM) (jsabo@frostedflakes) (0/pts/7) (~)
$ cd cobbler/
(10:03 PM) (jsabo@frostedflakes) (0/pts/7) (~/cobbler)
$ git log | grep 03834b92314a9f8df8a5d433c84c98ed2e6f573f
(10:03 PM) (jsabo@frostedflakes) (0/pts/7) (~/cobbler)
$ grep -r populate_mgmt * web/cobbler_web/templates/generic_edit.tmpl: populate_mgmt_classes();
It's not it the git master.
Confirmed, that patch was missed. _______________________________________________ cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Can you put it to your github or email us the patch?
It is/should be on my github, just wondering if shenson missed it? On Feb 25, 2011 11:11 AM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 10:16 PM, James Cammarata jimi@sngx.net wrote:
(09:30 PM) (jsabo@frostedflakes) (0/pts/7) (~)
$ git clone http://git.fedorahosted.org/git/cobbler Initialized empty Git repository in /home/jsabo/cobbler/.git/
(09:32 PM) (jsabo@frostedflakes) (0/pts/7) (~)
$ cd cobbler/
(10:03 PM) (jsabo@frostedflakes) (0/pts/7) (~/cobbler)
$ git log | grep 03834b92314a9f8df8a5d433c84c98ed2e6f573f
(10:03 PM) (jsabo@frostedflakes) (0/pts/7) (~/cobbler)
$ grep -r populate_mgmt * web/cobbler_web/templates/generic_edit.tmpl: populate_mgmt_classes();
It's not it the git master.
Confirmed, that patch was missed. _______________________________________________ cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Can you put it to your github or email us the patch?
On Fri, Feb 25, 2011 at 2:30 PM, James Cammarata jimi@sngx.net wrote:
It is/should be on my github, just wondering if shenson missed it?
On Feb 25, 2011 11:11 AM, "Jonathan Sabo" jsabo@criminal.org wrote:
On Thu, Feb 24, 2011 at 10:16 PM, James Cammarata jimi@sngx.net wrote:
> (09:30 PM) (jsabo@frostedflakes) (0/pts/7) (~)
$ git clone http://git.fedorahosted.org/git/cobbler Initialized empty Git repository in /home/jsabo/cobbler/.git/
> (09:32 PM) (jsabo@frostedflakes) (0/pts/7) (~)
$ cd cobbler/
> (10:03 PM) (jsabo@frostedflakes) (0/pts/7) (~/cobbler)
$ git log | grep 03834b92314a9f8df8a5d433c84c98ed2e6f573f
> (10:03 PM) (jsabo@frostedflakes) (0/pts/7) (~/cobbler)
$ grep -r populate_mgmt * web/cobbler_web/templates/generic_edit.tmpl: populate_mgmt_classes();
It's not it the git master.
Confirmed, that patch was missed. _______________________________________________ cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
Can you put it to your github or email us the patch?
I looked through master on your github and didn't see the commit you emailed us.
Can you put it to your github or email us the patch?
I looked through master on your github and didn't see the commit you emailed us.
Here is the commit:
https://github.com/jimi1283/cobbler/commit/03834b92314a9f8df8a5d433c84c98ed2...
As far as I can tell, it was on there. This thread was for a different patch I sent in.
On Sat, 26 Feb 2011 00:47:16 -0600, James Cammarata jimi@sngx.net wrote:
Can you put it to your github or email us the patch?
I looked through master on your github and didn't see the commit you emailed us.
Here is the commit:
https://github.com/jimi1283/cobbler/commit/03834b92314a9f8df8a5d433c84c98ed2...
As far as I can tell, it was on there. This thread was for a different patch I sent in.
I think I got it merged, it wasn't a clean one though. Can you check and make sure the new state is correct? Thanks.
On Mon, Feb 28, 2011 at 3:10 PM, Scott Henson shenson@redhat.com wrote:
On Sat, 26 Feb 2011 00:47:16 -0600, James Cammarata jimi@sngx.net wrote:
Can you put it to your github or email us the patch?
I looked through master on your github and didn't see the commit you emailed us.
Here is the commit:
https://github.com/jimi1283/cobbler/commit/03834b92314a9f8df8a5d433c84c98ed2...
As far as I can tell, it was on there. This thread was for a different patch I sent in.
I think I got it merged, it wasn't a clean one though. Can you check and make sure the new state is correct? Thanks.
I just did a clean clone and make, seems to be working for me - though others should test.
cobbler-devel@lists.fedorahosted.org