On 05/15/2015 11:57 AM, Mathieu Bridon wrote:
On Fri, 2015-05-15 at 11:48 -0400, Mike McLean wrote:
> FollowSymLinks is the default in apache 2.4, so unnecessary there.
>
https://httpd.apache.org/docs/current/mod/core.html#options
>
> For the folks still on 2.2 (which is probably a lot given that rhel6 has
> 2.2), I think setting either should be fine.
>
> This is just the default config, so users can adjust it as needed.
I sent this patch because I've been bitten by it 3 times now, everytime
spending some time trying to figure out what was going on.
So I just thought I'd save others the trouble (and myself, if I ever
deploy a new Koji :P), by adding it to the default config file.
However, if FollowSymlinks is the default in 2.4, then that makes it
much less needed, true.
Maybe something along the lines of what's in the default config file for
the Allow/Deny stuff, with a comment explaining that line must be
uncommented on Apache < 2.4 ?
Yeah, I was about to do that, but setting the option is harmless on 2.4,
plus I'm not 100% sure just how default it really is (experiments on my
laptop suggest I may be missing something).
I did add an extra comment for folks with odd /mnt/koji ownership.