Hi all,
This review takes into account the previous review recommendations:
- change args.get with default values
- change list() so that it returns
- default the environment file related to the instance
(/etc/sysconfig/dirsrv-<serverid> or
$HOME/.dirsrv/dirsrv-<serverid>)
- all the environment files if called with 'list(all=True)'
- change exists() to return 'len(self.list()) == 1'
- start() rebinds to the instance so that its final state is
DIRSRV_STATE_ONLINE
- List( ) returns a list of dictionaries. Each dictionary is
built from config files found under <prefix>/etc/sysconfig/dirsrv-* or
$HOME/.dirsrv/dirsrv-*. The dictionary contains a kind of
<propname>:<value> where propname are basically the environment variable
set in those file. By default, list () only returns its instance config
file (if it exists). Else it returns all the instances.
- minor changes to set the 'sroot' attribute from what is found
in SERVER_DIR of the config file
https://fedorahosted.org/389/attachment/ticket/47625/0003-Ticket-47625-CI...