389-devel August 2015

389-devel@lists.fedoraproject.org

8 participants
38 discussions

Start a nNew thread

please review: Ticket #47761 - Added a few testcases to the basic testsuite
by Simon Pichugin 15 Sep '15

15 Sep '15

https://fedorahosted.org/389/ticket/47761 https://fedorahosted.org/389/attachment/ticket/47761/0001-Ticket-47761-Adde…

1 2

Please review (memory leak): [389 Project] #48252: db2index creates index entry from deleted records
by Noriko Hosoi 15 Sep '15

15 Sep '15

https://fedorahosted.org/389/ticket/48252 https://fedorahosted.org/389/attachment/ticket/48252/0001-Ticket-48252-db2i… Description: Commit ca4d38dff3bd820af2bf60c9bcc82fd64aac2556 fixing ticket #48252 introduced memory leaks. . nstombstone_vals needs to be allocated just once and freed at the end. . when skipping to index an entry for being a tombstone, the entry needs to be freed.

2 1

[lib389] Deref control advice needed
by William Brown 02 Sep '15

02 Sep '15

Hi, In relation to ticket 47757, I have started work on a deref control for Noriko. The idea is to get it working in lib389, then get it upstreamed into pyldap. At this point it's all done, except that the actual request control doesn't appear to work. Could one of the lib389 / ldap python experts cast their eye over this and let me know where I've gone wrong? For one, I don't think that the DerferenceControl decodeControlValue function is ever called, as I'm never seeing the encodedControlValue printed in my logs. Second, the results I get from result3 are: [('cn=testgroup,dc=example,dc=com', {'objectClass': ['top', 'extensibleobject'], 'uniqueMember': ['uid=test,dc=example,dc=com'], 'cn': ['testgroup']})] [] Which again, doesn't seem correct, as there should be a result from the control. Additionally, any tips on how to make the code nicer would be appreciated. I've attached the complete patch, with a unit test to trigger the search, but the request control looks like: """ controlValue ::= SEQUENCE OF derefSpec DerefSpec DerefSpec ::= SEQUENCE { derefAttr attributeDescription, ; with DN syntax attributes AttributeList } AttributeList ::= SEQUENCE OF attr AttributeDescription """ class AttributeList(univ.SequenceOf): componentType = AttributeDescription() class DerefSpec(univ.Sequence): componentType = namedtype.NamedTypes( namedtype.NamedType('derefAttr', AttributeDescription()), namedtype.NamedType('attributes', AttributeList()), ) class ControlValue(univ.SequenceOf): componentType = DerefSpec() class DereferenceControl(LDAPControl): """ Dereference Control """ def __init__(self, criticality, deref): LDAPControl.__init__(self, CONTROL_DEREF, criticality) self.deref = deref def encodeControlValue(self): # How does -E ask for many values? derefAttr, attributes = self.deref.split(':') attributes = attributes.split(',') al = AttributeList() i = 0 while len(attributes) > 0: al.setComponentByPosition(i, attributes.pop()) i += 1 ds = DerefSpec() ds.setComponentByName('derefAttr', derefAttr) ds.setComponentByName('attributes', al) cv = ControlValue() cv.setComponentByPosition(0, ds) print(cv.prettyPrint()) return encoder.encode(cv) def decodeControlValue(self,encodedControlValue): print(encodedControlValue)

3 6

[lib389] review: Ticket #48262 Lib389 deref control search extension.
by William Brown 29 Aug '15

29 Aug '15

https://fedorahosted.org/389/ticket/48262 https://fedorahosted.org/389/attachment/ticket/48262/0001-Add-dereference-r… t-control-to-lib389-for-testin.patch -- William Brown <william(a)blackhats.net.au>

1 0

please review: Ticket 47931 - lib389 test script to verify memberof & retrocl deadlock
by Mark Reynolds 28 Aug '15

28 Aug '15

https://fedorahosted.org/389/ticket/47931/ https://fedorahosted.org/389/attachment/ticket/47931/0001-Ticket-47931-lib3…

1 0

Please review: #48258: dna plugin needs to handle binddn groups for authorization
by Ludwig Krispenz 27 Aug '15

27 Aug '15

https://fedorahosted.org/389/ticket/48258 https://fedorahosted.org/389/attachment/ticket/48258/0001-Ticket-48258-dna-…

1 0

Lib389 Aci parsing utilities
by William Brown 27 Aug '15

27 Aug '15

https://fedorahosted.org/389/ticket/48259 https://fedorahosted.org/389/attachment/ticket/48259/0001-Add-aci-parsing-u… ies-which-will-return-an-Entry.patch Relies on https://fedorahosted.org/389/ticket/48253 Sincerely, -- William Brown <william(a)blackhats.net.au>

1 0

Please review (regression): [389 Project] #48228: wrong password check if passwordInHistory is decreased.
by Noriko Hosoi 26 Aug '15

26 Aug '15

https://fedorahosted.org/389/ticket/48228 https://fedorahosted.org/389/attachment/ticket/48228/0001-Ticket-48228-wron…

1 1

Please review (2 tickets): #47757 and #48252
by Noriko Hosoi 25 Aug '15

25 Aug '15

#47757: Unable to dereference unqiemember attribute because it is dn [#UID] not dn syntax https://fedorahosted.org/389/ticket/47757 https://fedorahosted.org/389/attachment/ticket/47757/0001-Ticket-47757-Unab… #48252: db2index creates index entry from deleted records https://fedorahosted.org/389/ticket/48252 https://fedorahosted.org/389/attachment/ticket/48252/0001-Ticket-48252-db2i… https://fedorahosted.org/389/attachment/ticket/48252/0002-Ticket-48252-CI-t… https://fedorahosted.org/389/attachment/ticket/48252/0001-Ticket-48252-lib3…

1 0

Please review: [389 Project] #47757: Unable to dereference unqiemember attribute because it is dn [#UID] not dn syntax
by Noriko Hosoi 25 Aug '15

25 Aug '15

https://fedorahosted.org/389/ticket/47757 https://fedorahosted.org/389/attachment/ticket/47757/0001-Ticket-47757-Unab…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel August 2015