Hi,
I have been working on ticket #569 and reached a state where I would
like to get feedback. The latest update contains a link to a page on the
wiki and an attached patch file.
Please review both and let me know where you think more
investigation/explanation is needed and what your concerns are.
Thanks,
Ludwig
-------- Original Message --------
Subject: Re: [389 Project] #569: examine replication code to reduce
amount of stored state information
Date: Wed, 20 Mar 2013 14:03:01 -0000
From: 389 Project <389-trac(a)fedorahosted.org>
Reply-To: nobody(a)fedoraproject.org
To: undisclosed-recipients:;
#569: examine replication code to reduce amount of stored state information
------------------------------------------+---------------------------
Reporter: lkrispen | Owner: lkrispen
Type: task | Status: assigned
Priority: major | Milestone: 1.3.2
Component: Replication - General | Version: 1.3.0
Resolution: | Keywords:
Blocked By: | Blocking:
Review: | Ticket origin: Community
Red Hat Bugzilla: | Screened: 1
------------------------------------------+---------------------------
Comment (by lkrispen):
The current status of the document is here:
http://port389.org/wiki/Entry_State_Resolution
The current state of the implementation is in the attached patch file.
What still needs to be done:
- complete the test cases and create test scripts
- verify acceptance test results, some tests fail since they examine
deleted values and value csns based on the old algorithm, need to modify
these test cases.
- there is one test failing because server seems to crash, need to
investigate this
- code also contains fix for ticket #602 by setting subsequence numbers,
investigate if this is correct for all usages of csn_compare or if
csn_compare needs to be differentiated
--
Ticket URL: <https://fedorahosted.org/389/ticket/569#comment:6>
389 Project <http://port389.org>
389 Directory Server
https://fedorahosted.org/389/ticket/627https://fedorahosted.org/389/attachment/ticket/627/0001-Ticket-627-ns-slapd…
Bug Description: Schema reload task (schema-reload.pl) was not
thread safe.
Fix Description: Attribute Syntax is stored in the hash and
retrieved based upon the attribute syntax. When Schema reload
task is invoked, the attribute syntax objects were completely
replaced ignoring the lock protection. This patch protects
the attribute syntax replacement (attr_syntax_delete_all_for_
schemareload) with the write lock. Also, attribute syntax
object maintains the reference count. The schema reload
respects the reference count instead of blindly deleting them.