389-devel August 2016

389-devel@lists.fedoraproject.org

12 participants
46 discussions

Please review: ticket #48766 Replication changelog can incorrectly skip over updates
by Ludwig Krispenz 09 Sep '16

09 Sep '16

This is the latest version of the "changelog buffer processing" fixes. https://fedorahosted.org/389/ticket/48766 https://fedorahosted.org/389/attachment/ticket/48766/0001-reworked-clcach-b… The background for the fix is here, I would like to get feedback on this as well to clarify what is unclear http://www.port389.org/docs/389ds/design/changelog-processing-in-repl-state… -- Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill

2 5

Build failed in Jenkins: 389-ds-base #1061
by jenkins＠fedoraproject.org 31 Aug '16

31 Aug '16

See <http://jenkins.fedorainfracloud.org/job/389-ds-base/1061/changes> Changes: [William Brown] Ticket 48805 - Misleading indent and Uninitialised struct member [William Brown] Ticket 48805 - Sign comparison checks. ------------------------------------------ Started by an SCM change Building remotely on F23 (fedora Fedora23 Fedora fedora23) in workspace <http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/> Wiping out workspace first. Cloning the remote Git repository Cloning repository git://git.fedorahosted.org/git/389/ds.git > git init <http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/> # timeout=10 Fetching upstream changes from git://git.fedorahosted.org/git/389/ds.git > git --version # timeout=10 > git -c core.askpass=true fetch --tags --progress git://git.fedorahosted.org/git/389/ds.git +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url git://git.fedorahosted.org/git/389/ds.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://git.fedorahosted.org/git/389/ds.git # timeout=10 Fetching upstream changes from git://git.fedorahosted.org/git/389/ds.git > git -c core.askpass=true fetch --tags --progress git://git.fedorahosted.org/git/389/ds.git +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10 Checking out Revision 3e7d6d62f3b2889d0250cb0a3892982e42ada878 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 3e7d6d62f3b2889d0250cb0a3892982e42ada878 > git rev-list 942c1af6f0c963f01671dadca8571995f332aaf3 # timeout=10 [389-ds-base] $ /bin/sh -e /tmp/hudson8866388837661328119.sh Running configure... CFLAGS= -Wall CXXFLAGS= -Wall ./configure --with-tmpfiles-d=/etc/tmpfiles.d --with-openldap --enable-autobind --enable-gcc-security --with-selinux --with-systemdsystemunitdir=/lib/systemd/system --with-systemdsystemconfdir=/etc/systemd/system --enable-debug Build log is http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/build.1061.txt Running make... Build log is http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/build.1061.txt Checking for warnings... Build http://jenkins.fedorainfracloud.org/job/389-ds-base/1061/ failed There are build warnings Warning log is http://jenkins.fedorainfracloud.org/job/389-ds-base/ws/build-warns.1061.txt Last 100 lines of warning log: ------------------------------------------------------------ ldap/servers/slapd/tools/dbscan.c:1072:12: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘size_t {aka long unsigned int}’ [-Wformat=] ------------------------------------------------------------ Build step 'Execute shell' marked build as failure

1 2

389-ds-base source has been branched to 1.3.5
by Mark Reynolds 31 Aug '16

31 Aug '16

The master branch in the 389-ds-base source code has been branched to 389-ds-base-1.3.5. The master branch will now be for 1.3.6 commits. Thanks, Mark

1 0

please review: Ticket 48832 - fix CI test failures
by Mark Reynolds 31 Aug '16

31 Aug '16

https://fedorahosted.org/389/ticket/48832 https://fedorahosted.org/389/attachment/ticket/48832/0001-Ticket-48832-Fix-…

1 0

Please review: 48951, dsconf plugin commands
by William Brown 31 Aug '16

31 Aug '16

https://fedorahosted.org/389/ticket/48951 https://fedorahosted.org/389/attachment/ticket/48951/0001-Ticket-48951-dsad… -- Sincerely, William Brown Software Engineer Red Hat, Brisbane

1 0

please review: Ticket 48975 - Disabled CLEAR password storage scheme plugin causes crash when replacing userpassword
by Mark Reynolds 30 Aug '16

30 Aug '16

https://fedorahosted.org/389/ticket/48975 https://fedorahosted.org/389/attachment/ticket/48975/0001-Ticket-48975-Disa…

1 0

please review: Ticket 48970 - Server side sorting crashes the server
by Mark Reynolds 30 Aug '16

30 Aug '16

https://fedorahosted.org/389/ticket/48970 https://fedorahosted.org/389/attachment/ticket/48970/0001-Ticket-48970-Serv…

1 0

Re: Sign compare checking
by Howard Chu 30 Aug '16

30 Aug '16

> Date: Mon, 29 Aug 2016 11:43:27 -0600 > From: Rich Megginson <rmeggins(a)redhat.com> > Subject: [389-devel] Re: Sign compare checking > To: 389-devel(a)lists.fedoraproject.org > Message-ID: <a7fdb987-8efa-d26d-08c1-3cf0ecb59c5e(a)redhat.com> > Content-Type: multipart/alternative; boundary="------------ > 2A83E5142B304396ABB138B7" > Part of the problem is that we wanted to support being able to use both > mozldap and openldap, without too much "helper" code/macros/#ifdef > MOZLDAP/etc. It looks as though this is a place where we need to have > some sort of helper. > > (as for why we still support mozldap - we still need an ldap c sdk that > supports NSS for crypto until we can fix that in the server. Once we > change 389 so that it can use openldap with openssl/gnutls for crypto, > we should consider deprecating support for mozldap.) What support for MozNSS is OpenLDAP lacking? Support for MozNSS has been in there for ages now. Patches to make Mozilla work with OpenLDAP instead of mozldap have also been available for ages. https://bugzilla.mozilla.org/show_bug.cgi?id=292127#c17 through comment #30 -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

2 1

Please review: Ticket 48369 - Add CI test suite
by Simon Pichugin 30 Aug '16

30 Aug '16

Hi team, Punit has written the test suite and I have refactored it a bit. Please, review it. :) https://fedorahosted.org/389/ticket/48369 https://fedorahosted.org/389/attachment/ticket/48369/0001-Ticket-48369-Add-… Thanks, Simon

1 0

Re: 389-devel Digest, Vol 134, Issue 9
by ALI KATOUZIAN 30 Aug '16

30 Aug '16

Hi please remove me from the list.thanks Ali Katouzian Bolourforoush Use SiteAdvisor www.siteadvisor.com From: "389-devel-request(a)lists.fedoraproject.org" <389-devel-request(a)lists.fedoraproject.org> To: 389-devel(a)lists.fedoraproject.org Sent: Monday, August 29, 2016 6:13 AM Subject: 389-devel Digest, Vol 134, Issue 9 Send 389-devel mailing list submissions to 389-devel(a)lists.fedoraproject.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.o… or, via email, send a message with subject or body 'help' to 389-devel-request(a)lists.fedoraproject.org You can reach the person managing the list at 389-devel-owner(a)lists.fedoraproject.org When replying, please edit your Subject line so it is more specific than "Re: Contents of 389-devel digest..." Today's Topics: 1. please review: Ticket 48972 - remove old legacy password policy code that used ACI's (Mark Reynolds) 2. Jenkins build is back to normal : 389-DS-COMMIT #93 (Jenkins) 3. Adding vCard Schema (kashefi(a)arissystem.com) 4. Re: Adding vCard Schema (Rich Megginson) 5. Jenkins build is back to normal : 389-DS-CI #63 (Jenkins) 6. Reminder: Please Review: ns + ds tickets (William Brown) 7. Sign compare checking (William Brown) 8. Re: Sign compare checking (William Brown) ---------------------------------------------------------------------- Date: Fri, 26 Aug 2016 18:57:57 -0400 From: Mark Reynolds <mareynol(a)redhat.com> Subject: [389-devel] please review: Ticket 48972 - remove old legacy password policy code that used ACI's To: "389 Directory server developer discussion." <389-devel(a)lists.fedoraproject.org> Message-ID: <ef84c49e-52dd-27b0-d6eb-60e7b2134186(a)redhat.com> Content-Type: text/plain; charset=utf-8 https://fedorahosted.org/389/ticket/48972 https://fedorahosted.org/389/attachment/ticket/48972/0001-Ticket-48972-remo… ------------------------------ Date: Sat, 27 Aug 2016 04:50:00 +0200 (CEST) From: Jenkins <mareynol(a)redhat.com> Subject: [389-devel] Jenkins build is back to normal : 389-DS-COMMIT #93 To: 389-devel(a)lists.fedoraproject.org, mareynol(a)redhat.com, mreynolds(a)redhat.com Message-ID: <770701762.0.1472266200038.JavaMail.jenkins(a)vm-058-081.abc .idm.lab.eng.brq.redhat.com> Content-Type: text/plain; charset=UTF-8 See <http://vm-058-081.abc.idm.lab.eng.brq.redhat.com:8080/job/389-DS-COMMIT/93/> ------------------------------ Date: Sat, 27 Aug 2016 11:49:19 -0000 From: kashefi(a)arissystem.com Subject: [389-devel] Adding vCard Schema To: 389-devel(a)lists.fedoraproject.org Message-ID: <20160827114919.10245.90701(a)mailman01.phx2.fedoraproject.org> Content-Type: text/plain; charset="utf-8" Hello, Is it possible for you to include vCard schema in 389ds by default? https://tools.ietf.org/html/draft-gryphon-ldap-schema-vcard4-00 Best Regards Kianoosh Kashefi ------------------------------ Date: Sat, 27 Aug 2016 08:17:52 -0600 From: Rich Megginson <rmeggins(a)redhat.com> Subject: [389-devel] Re: Adding vCard Schema To: "389 Directory server developer discussion." <389-devel(a)lists.fedoraproject.org> Message-ID: <78d805bd-ba1d-ed7e-b14f-07a41fa7a755(a)redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed On 08/27/2016 05:49 AM, kashefi(a)arissystem.com wrote: > Hello, > > Is it possible for you to include vCard schema in 389ds by default? > > https://tools.ietf.org/html/draft-gryphon-ldap-schema-vcard4-00 Please file a ticket at https://fedorahosted.org/389/newticket > > Best Regards > Kianoosh Kashefi > -- > 389-devel mailing list > 389-devel(a)lists.fedoraproject.org > https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.o… ------------------------------ Date: Sun, 28 Aug 2016 04:30:31 +0200 (CEST) From: Jenkins <mareynol(a)redhat.com> Subject: [389-devel] Jenkins build is back to normal : 389-DS-CI #63 To: 389-devel(a)lists.fedoraproject.org Message-ID: <59090307.1.1472351431643.JavaMail.jenkins(a)vm-058-081.abc. idm.lab.eng.brq.redhat.com> Content-Type: text/plain; charset=UTF-8 See <http://vm-058-081.abc.idm.lab.eng.brq.redhat.com:8080/job/389-DS-CI/63/> ------------------------------ Date: Mon, 29 Aug 2016 09:34:59 +1000 From: William Brown <wibrown(a)redhat.com> Subject: [389-devel] Reminder: Please Review: ns + ds tickets To: 389-devel <389-devel(a)lists.fedoraproject.org> Message-ID: <1472427299.28186.18.camel(a)redhat.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-c34B3GxGrKZ3Mb6sVsh+" --=-c34B3GxGrKZ3Mb6sVsh+ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Nunc-stans, These have been waiting for a while: https://fedorahosted.org/nunc-stans/ticket/57 https://fedorahosted.org/nunc-stans/attachment/ticket/57/0001-Ticket-57-Abi= lity-to-disarm-a-persistent-job-from-wi.patch https://fedorahosted.org/nunc-stans/ticket/58 https://fedorahosted.org/nunc-stans/attachment/ticket/58/0001-Ticket-58-Add= -stress-test.2.patch Directory Server https://fedorahosted.org/389/ticket/397 https://fedorahosted.org/389/attachment/ticket/397/0001-Ticket-397-Implemen= t-scrypt-hashing-mechanism-for-DS.2.patch --=20 Sincerely, William Brown Software Engineer Red Hat, Brisbane --=-c34B3GxGrKZ3Mb6sVsh+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAABAgAGBQJXw3UjAAoJEISUiynM+PAgl1QQAIeV+zDZy/kv5rM3J5xBJe0f gVQWANTT0QC9/oCpl9GLCRVHbmzJlribgdoEhmtF0ji+x2o2q2hBEg46GHAzjNQG 6XaBuQvve9U6VB0AcMXxFhH2hT2YFzEhXGF128G9zwO9QXIKkrY6QOH1PujbP7ZK MiOPzo2bQ9uX0oRWNAGGVi31Jq1IMhuea2xi5YNRm2X5FCGuk2rpceHXb8gXKFJh D86eKvkU4u8NTjMdkMhRu3aP777jyVRD3EUng+BcVzb46Ok7z0Su8DmO25diWJQe Icp5j14qSgdClx68uz33RrtUAJdSx0cabHMgHdvqSVvU+x+MBt0lRS/MaBN82bYV YxCPb5Aezw0tGUVPIoDqBqpcBH81N5P96DymBp87QqO4GHnS2BvNh+Ra3SMJCw6x 3jBFT5/qv7lzsFXYunIwmbryF8wR+FAh2wQOopIzqFiHo7JNFSQ/QIyXo3BOqHZW mnj9WW+AkQCLHcj4n/3LzccWe7y1VKohsvXulNhwHfGVUR4VIEmJWbmt+SfhDpAS 7B+3y4pI5OjtEA5077lbygcjloOT8eHCwZW1hcujYHHSbUy1VyMJOwS9DsQjCE8W au8GhEJNkAwUjiHoHFjRVFS+jGXzwJ8GTjC/YeAcb7d7FRGHykYk2/gJZ5o1SIn7 +wHPNcbn7G2ZH+DZwttM =uGLD -----END PGP SIGNATURE----- --=-c34B3GxGrKZ3Mb6sVsh+-- ------------------------------ Date: Mon, 29 Aug 2016 14:36:27 +1000 From: William Brown <wibrown(a)redhat.com> Subject: [389-devel] Sign compare checking To: 389-devel <389-devel(a)lists.fedoraproject.org> Message-ID: <1472445387.28186.21.camel(a)redhat.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-HwetbhPf/V4gaBe4aI6x" --=-HwetbhPf/V4gaBe4aI6x Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I'm going through the list of sign-compare errors from gcc, and putting in the appropriate casts (uint -> int normally). I found in filter.c: /* openldap does not return LBER_END_OF_SEQORSET - so check for len =3D=3D -1 - openldap ber_next_element will not set len if it has reached the end, and -1 is not a valid value for a real len */ if ( (tag !=3D LBER_END_OF_SEQORSET) && (len !=3D -1) && (*fstr != =3D NULL) ) { LDAPDebug( LDAP_DEBUG_ANY, " error parsing filter list \n", 0, 0, 0 ); slapi_ch_free((void**)fstr ); } However, len is a ber_len_t, which is a typedef uint. It's actually impossible for this value to hold a -1. So either, this is a bug in the way openldap uses the ber_len_t type, we have a mistake in our logic, or something else hokey is going on.=20 I would like to update this to: if ( (tag !=3D LBER_END_OF_SEQORSET) && (len =3D=3D 0) && (*fstr !=3D NULL)= ) Or even: if ( (tag !=3D LBER_END_OF_SEQORSET) && (*fstr !=3D NULL) ) What do you think of this assessment given the ber_len_t type?=20 --=20 Sincerely, William Brown Software Engineer Red Hat, Brisbane --=-HwetbhPf/V4gaBe4aI6x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAABAgAGBQJXw7vLAAoJEISUiynM+PAg2WcP/Ayln23mWYUjdDeM14CceLTM BI7Dx4OOd+6x9HqbeoLA+cwqESluW6+96E8m1Uv13MJANoXpEyb11/ezKN/ooY91 4ImFFsRRZHQO5Ezk2QBEvxQfk0x2fYFHnv1fRp0MvZf0RTdEZ/iSF3eqKPske06V sfBOh6RWOmK8FKHLXYr+Si1RxSrOojy/8QzSzIn0ojgYqkhSN1TZkylTHd3kEXFZ n31zhxdweTmfyQvCe5HtBs3urRUAHoUveWBs14ccNnSu36XfPJE5AtKPnXntW+GZ 6J9qrY/zux0jeF8/XDYQt2SThWdMTQmkOlvRxF8p0s2yWLgZ7RLkrG9EAmMfJ2T6 abPFjnbJQ6ZMfXGsmQvXl1iT6x3bsh4Uz1zro55BKK4VE9f8VIvhPtFXtWv9IO7Q C3IyclFzTvoNyuqF3bKo5Bfva8n/U/1R/oMjOYK9Hr7gDbJ+JgZ9rfaf1DJesuMd 0d4XU0mhmHY/vQ/xWkS+ERxU+/RIzr9fwq0+RhE+CweZWXOcFUZ9TlO03GrFMdMn NFtzz3sRX5Bm/qzPc5QWdp/h+MmO0Zrm6U0L17Y3Fp69maiR2WITGF/nVjziFmMd HEc4TXJQgZVjx+Kv9/wYLfST8NhE8CEWdPRtNyFa/lruvJFda6UYEFHazYfeU72f QdD5sYfVGsIjQnB9FPSX =RFa8 -----END PGP SIGNATURE----- --=-HwetbhPf/V4gaBe4aI6x-- ------------------------------ Date: Mon, 29 Aug 2016 15:13:39 +1000 From: William Brown <wibrown(a)redhat.com> Subject: [389-devel] Re: Sign compare checking To: "389 Directory server developer discussion." <389-devel(a)lists.fedoraproject.org> Message-ID: <1472447619.28186.24.camel(a)redhat.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-RxNqnIBHeMvqSAwawzLI" --=-RxNqnIBHeMvqSAwawzLI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable >=20 > So either, this is a bug in the way openldap uses the ber_len_t type, we > have a mistake in our logic, or something else hokey is going on.=20 >=20 > I would like to update this to: >=20 > if ( (tag !=3D LBER_END_OF_SEQORSET) && (len =3D=3D 0) && (*fstr !=3D NUL= L) ) >=20 > Or even: >=20 > if ( (tag !=3D LBER_END_OF_SEQORSET) && (*fstr !=3D NULL) ) >=20 > What do you think of this assessment given the ber_len_t type?=20 Looks like it's intentional by the openldap team. There are some other areas for this problem. Specifically: int ber_printf(BerElement *ber, const char *fmt, ...); lber.h:79:#define LBER_ERROR ((ber_tag_t) -1) We check if (ber_printf(...) !=3D LBER_ERROR) Of course, we can't satisfy either. We can't cast the LBER_ERROR from uint -> int without changing the value of it, and we can't cast the output of ber_printf from int -> uint, again, without potentially changing the value of it. So it seems that the openldap library may be impossible to satisfy the gcc type checking with -Wsign-compare. For now, I may just avoid these in my fixes, as it seems like a whole set of landmines I want to avoid ...=20 --=20 Sincerely, William Brown Software Engineer Red Hat, Brisbane --=-RxNqnIBHeMvqSAwawzLI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAABAgAGBQJXw8SDAAoJEISUiynM+PAgP28P/2wO0bFVtUSZ1jLXmNQCwWJP 85s7vnZ2u0U5Dym8QkPxjz4AIR6LZCZ+Jbk5zRNWkw3+fsdf7j2MTGjTSSiZhZYJ rWkNJx1YJ8vp9F15ckwLtk2ARLZOjM4AOV4a6v3PiWFoTveUQUp5xRX2j+/P3cou GCp1/QP4ZjXba76EQ2lrDGvpfJBm1Wb9Vv+86s8w7B9DkSJOwV3OKDoNaZTv4ngK fbVPaBdTgec6AiqFH66vRre1JMtVcTYPNpf4rOrCYU+hfKR0O7M+tpXGa+VGmFJn ZdRt/Y9RXkl2veaXYXGIcylmCBmvOTI39YZz7lKBokG+KbdsIB0mVBgyQMg+kaLz X7Q6QSvuuDgbgRkfqwRzkUJCXf9NArHsmayq3Jx2SVCr5YxK6KtKmP4bchUBuCno smCHj139+Pbr9hKbHQvg6VATU5XU6zOM0dLJRGFSk3ihT369QmM7pvf9Oh7FGtLq HIeX7jaqLQpANwPkbsVljNaBZN0bWPpndf5CNT9bHPN/GVUW+Wtlq7WFamme3MHV dpkpMNi7EKDI2NLAjhjthqvMJMTCO+X/aJ+Fu0i506gtJKUdGnFVMnJSNPcwAAxk 8gv50Oa/I0d0j4HIEqP+jDFUWu7ivV6NDVGApsaU/IqfBx5SX7DHFIqK7jShGQfI 0kKiWsKVnGqorG+Os0xT =/mYD -----END PGP SIGNATURE----- --=-RxNqnIBHeMvqSAwawzLI-- ------------------------------ Subject: Digest Footer -- 389-devel mailing list 389-devel(a)lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.o… ------------------------------ End of 389-devel Digest, Vol 134, Issue 9 *****************************************

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel August 2016