From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net nm: nmdbus connections settings report race fix
......................................................................
Patch Set 3: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/77795
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3589eb4a3369b319d034489523bf900b7a17206d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl bindings, route functions
......................................................................
network: isolate libnl bindings, route functions
Change-Id: I39c90dcdd2eba3016fb92c1d4379d7c42023bb33
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/route.py
3 files changed, 163 insertions(+), 49 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77420
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39c90dcdd2eba3016fb92c1d4379d7c42023bb33
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl bindings, address functions
......................................................................
network: isolate libnl bindings, address functions
Change-Id: I2d2f2715166674c87547221de4f828bab7a66024
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/addr.py
M lib/vdsm/network/netlink/libnl.py
2 files changed, 110 insertions(+), 41 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d2f2715166674c87547221de4f828bab7a66024
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl constants, callback actions
......................................................................
network: isolate libnl constants, callback actions
Change-Id: Ic2646ccffaaa5cd39a23de20359943fd31cbc964
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/monitor.py
3 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2646ccffaaa5cd39a23de20359943fd31cbc964
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl bindings, link functions
......................................................................
network: isolate libnl bindings, link functions
Change-Id: I66e009d97b123602f047a17f283a8c776bda1dcc
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/link.py
3 files changed, 316 insertions(+), 88 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77193
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66e009d97b123602f047a17f283a8c776bda1dcc
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl bindings, cache functions
......................................................................
network: isolate libnl bindings, cache functions
Change-Id: I0339db69090b59901a0f28cc7d470b709913ba16
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/addr.py
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/link.py
M lib/vdsm/network/netlink/route.py
5 files changed, 44 insertions(+), 14 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76784
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0339db69090b59901a0f28cc7d470b709913ba16
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl constants, interface state
......................................................................
network: isolate libnl constants, interface state
Change-Id: Iac07ac94055fb0a21ee99f0b54e2d3c51b10a673
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/ipwrapper.py
M lib/vdsm/network/link/iface.py
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/link.py
M tests/network/ipwrapper_test.py
5 files changed, 34 insertions(+), 28 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77423
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac07ac94055fb0a21ee99f0b54e2d3c51b10a673
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl constants, EVENTS
......................................................................
network: isolate libnl constants, EVENTS
Change-Id: I8252b9b086840fe608d6a4a4cfa162da32aed587
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/monitor.py
2 files changed, 45 insertions(+), 45 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77421
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8252b9b086840fe608d6a4a4cfa162da32aed587
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl bindings, socket functions
......................................................................
network: isolate libnl bindings, socket functions
Change-Id: Ia3710c1afa95bfc356a6b05a83409f0352230fdd
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/monitor.py
3 files changed, 188 insertions(+), 81 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76782
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3710c1afa95bfc356a6b05a83409f0352230fdd
Gerrit-PatchSet: 36
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl bindings, object and message functions
......................................................................
network: isolate libnl bindings, object and message functions
Change-Id: If4d2c3be48cde55ada212793e4490dda0854cd12
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/monitor.py
3 files changed, 71 insertions(+), 18 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76787
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4d2c3be48cde55ada212793e4490dda0854cd12
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>