Change in vdsm[master]: spec: Handle VDSM services restart on upgrade to posttrans
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Handle VDSM services restart on upgrade to posttrans
......................................................................
Patch Set 2:
any reason its not in yet?
--
To view, visit https://gerrit.ovirt.org/77785
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16793ff6ca1fcf596f57b459fa4ed348a879b104
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: network: decode command output to native string
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: decode command output to native string
......................................................................
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/77724/25/lib/vdsm/network/cmd.py
File lib/vdsm/network/cmd.py:
PS25, Line 62: 'utf-8'
> python -c "print('\xe3')"
My point is that
'\xe3'.decode('utf8')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib64/python2.7/encodings/utf_8.py", line 16, in decode
return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xe3 in position 0: unexpected end of data
if an app prints this bytestream, the consumer should be aware that this is not utf8.
I don't think we should handle this right now. You can keep this py3 bug if you add a failing test for it.
In one point in the future, we can differentiate between consumers that need bytes to those needing unicode.
--
To view, visit https://gerrit.ovirt.org/77724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39ed13161487cff4f531f513a25a1c74787cf2df
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: pthread: Move pthread module to common
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pthread: Move pthread module to common
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/77984
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I464a19f40c8cfcedefe15aab6bc77967206b2c40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: ssl: enable tlsv1.2 support
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support
......................................................................
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/72284/27/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
PS27, Line 227: tlsv1.2
> BZ1451297 is a different bug and we will need a different patch to fix it.
... unless we have our nice Ansible/host-deploy integration. With it, it would be a breeze to configure
ssl_protocol=OP_NO_TLSv1,OP_NO_TLSv1_1
on all hosts belonging to clusterLevel >= 4.0.
--
To view, visit https://gerrit.ovirt.org/72284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: network: decode command output to native string
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: decode command output to native string
......................................................................
Patch Set 25: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/77724/25/lib/vdsm/network/cmd.py
File lib/vdsm/network/cmd.py:
PS25, Line 62: 'utf-8'
we should remember (and note in exec_sync doc string) that a generic application may output non-utf8 output, e.g.
python -c "print('\xe3')"
yet we assume that all of our command lines behave. If we take this cowardly course, let us add an xfail test, as a TODO to our future selves.
--
To view, visit https://gerrit.ovirt.org/77724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39ed13161487cff4f531f513a25a1c74787cf2df
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: network: make ipwrapper.drv_name Python 3 compatible
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: make ipwrapper.drv_name Python 3 compatible
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/77940/7/lib/vdsm/network/ipwrapper.py
File lib/vdsm/network/ipwrapper.py:
Line 255:
Line 256: Throws IOError ENODEV for non existing devices.
Line 257: Throws IOError EOPNOTSUPP for non supported devices, i.g., loopback.
Line 258: """
Line 259: encoded_name = devName.encode('utf-8')
it would be extremely cowardly, but the easiest way to make this pass is to add a condition here.
if devName is string: encode()
if bytes: keep
The noble thing to do is to make sure that devName has a specific type. I suspect that it has to be bytes, since the kernel would accept non-utf8 string of bytes as interface names.
Line 260: ETHTOOL_GDRVINFO = 0x00000003 # ETHTOOL Get driver info command
Line 261: SIOCETHTOOL = 0x8946 # Ethtool interface
Line 262: DRVINFO_FORMAT = '= I 32s 32s 32s 32s 32s 12s 5I'
Line 263: IFREQ_FORMAT = '16sPi' # device_name, buffer_pointer, buffer_len
--
To view, visit https://gerrit.ovirt.org/77940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dee4fd4a1ac5470e739594704da5781589af1d3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: remove upgrade hacks for older versions
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: remove upgrade hacks for older versions
......................................................................
remove upgrade hacks for older versions
Change-Id: I7ec84b22905200f6189891785e4367889ce28bde
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M init/vdsmd_init_common.sh.in
M vdsm.spec.in
2 files changed, 0 insertions(+), 20 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/77780/1
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index cbec4a6..4e50ecb 100755
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -195,24 +195,6 @@
}
-task_upgraded_version_check(){
- local upgraded_ver_file="@VDSMLIBDIR@/upgraded_version"
- if [ -f "${upgraded_ver_file}" ]; then
- local ret=0
- if grep -q '^vdsm-4\.10\.' "${upgraded_ver_file}"; then
- # REQUIRED_FOR upgrade from vdsm-4.10.x
- "$VDSM_TOOL" configure --force
- ret=$?
- elif grep -qE '^vdsm-4\.(13|14|16)\.' "${upgraded_ver_file}"; then
- # REQUIRED_FOR upgrade from 4.13.x or 4.14.x or 4.16.x
- # mutlipath and sasl password configuration logic moved to
- # vdsm-tool in 4.17.
- "$VDSM_TOOL" configure --module multipath --module passwd
- ret=$?
- fi
- [ "${ret}" -eq 0 ] && rm -f "${upgraded_ver_file}"
- fi
-}
#### pre-start tasks end ####
@@ -250,7 +232,6 @@
configure_vdsm_logs \
wait_for_network \
run_init_hooks \
- upgraded_version_check \
check_is_configured \
validate_configuration \
prepare_transient_repository \
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 6936958..1798d33 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -772,7 +772,6 @@
/usr/sbin/usermod -a -G %{cdrom_group} %{qemu_user}
# We keep the previous rpm version number in a file for managing upgrade flow
-# in vdsmd_init_script upgraded_version_check task
if [ "$1" -gt 1 ]; then
rpm -q %{vdsm_name} > "%{_localstatedir}/lib/%{vdsm_name}/upgraded_version"
fi
--
To view, visit https://gerrit.ovirt.org/77780
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ec84b22905200f6189891785e4367889ce28bde
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years
Change in vdsm[master]: spec: Use systemctl directly instead of vdsm-tool where poss...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: Use systemctl directly instead of vdsm-tool where possible
......................................................................
spec: Use systemctl directly instead of vdsm-tool where possible
There is no longer a need to wrap service control using vdsm-tool as we
support only systemd anyway.
Change-Id: Icee1b785cd5d869599e5fca3edd8fa84022b4475
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77784
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icee1b785cd5d869599e5fca3edd8fa84022b4475
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: ssl: enable tlsv1.2 support
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support
......................................................................
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/72284/27/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
PS27, Line 227: tlsv1.2
> the text of the bug agrees with it, too
please note that my idea suggest that you dynamically look for the constant value with
getattr(ssl, whatever_in_the_conf_file)
so you don't need any hard-coded values for protocols, only to warn or crash if you have an invalid value.
--
To view, visit https://gerrit.ovirt.org/72284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: ssl: enable tlsv1.2 support
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support
......................................................................
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/72284/27/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
PS27, Line 227: tlsv1.2
> I like the exclude list. Will update.
the text of the bug agrees with it, too
Bug 1451297 - [RFE] Drop TLSv1 and TLSv1.1 encryption protocols support
--
To view, visit https://gerrit.ovirt.org/72284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years