Change in vdsm[master]: cmdutils: Relocate *_log_line funcs to common.cmdutils
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: cmdutils: Relocate *_log_line funcs to common.cmdutils
......................................................................
cmdutils: Relocate *_log_line funcs to common.cmdutils
Moving command_log_line and retcode_log_line to common.cmdutils.
Change-Id: I36f08db1db5fa151210c21f043fb9161607ba324
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/cmdutils.py
M lib/vdsm/commands.py
M lib/vdsm/common/cmdutils.py
M lib/vdsm/network/cmd.py
M lib/vdsm/qemuimg.py
M lib/vdsm/storage/operation.py
M lib/vdsm/v2v.py
M tests/cmdutils_test.py
M tests/common/cmdutils_test.py
9 files changed, 92 insertions(+), 90 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77507
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36f08db1db5fa151210c21f043fb9161607ba324
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: cmdutils: Relocate systemd_run to common.cmdutils
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: cmdutils: Relocate systemd_run to common.cmdutils
......................................................................
cmdutils: Relocate systemd_run to common.cmdutils
systemd_run is moved from vdsm.cmdutils to common.cmdutils, allowing its
callers to depend on common.
Change-Id: I60a05c15f2e888d2fe6dfd9173ebf3f9016c4cc6
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/cmdutils.py
M lib/vdsm/common/cmdutils.py
M lib/vdsm/network/cmd.py
M lib/vdsm/storage/mount.py
M lib/vdsm/supervdsm_api/systemd.py
M tests/cmdutils_test.py
M tests/common/cmdutils_test.py
7 files changed, 72 insertions(+), 72 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60a05c15f2e888d2fe6dfd9173ebf3f9016c4cc6
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: constants: Move EXT_SYSTEMD_RUN from constants to cmdutils
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: constants: Move EXT_SYSTEMD_RUN from constants to cmdutils
......................................................................
constants: Move EXT_SYSTEMD_RUN from constants to cmdutils
EXT_SYSTEMD_RUN is used only by cmdutils and there seem to be no
apparent reason to allow its bin path to change.
The move was triggered by the need to move cmdutils functions to common
and avoid large scale changes, like moving constants to common.
Change-Id: I0def7a0d36e25184220cadbc78c575107d8c31c5
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M configure.ac
M lib/vdsm/cmdutils.py
M lib/vdsm/constants.py.in
M tests/cmdutils_test.py
4 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77508
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0def7a0d36e25184220cadbc78c575107d8c31c5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: compat: Move compat module to common
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: compat: Move compat module to common
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3693cac5ed36d2a9bd89d59bf0fd41049e57aa
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: cmdutils: Relocate systemd_run to common.cmdutils
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: cmdutils: Relocate systemd_run to common.cmdutils
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60a05c15f2e888d2fe6dfd9173ebf3f9016c4cc6
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: constants: Move EXT_SYSTEMD_RUN from constants to cmdutils
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: constants: Move EXT_SYSTEMD_RUN from constants to cmdutils
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77508
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0def7a0d36e25184220cadbc78c575107d8c31c5
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: cmdutils: Relocate *_log_line funcs to common.cmdutils
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: cmdutils: Relocate *_log_line funcs to common.cmdutils
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77507
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36f08db1db5fa151210c21f043fb9161607ba324
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: network: remove blacklisted tests fixed by netlink refactoring
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: remove blacklisted tests fixed by netlink refactoring
......................................................................
network: remove blacklisted tests fixed by netlink refactoring
Change-Id: I61adada273873bf8f9c08f0bcabf8543a60fb13b
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M tests/Makefile.am
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77429
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61adada273873bf8f9c08f0bcabf8543a60fb13b
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: network: remove blacklisted tests fixed by netlink refactoring
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: remove blacklisted tests fixed by netlink refactoring
......................................................................
Patch Set 25: Verified+1
passing CI is good enough for this one.
--
To view, visit https://gerrit.ovirt.org/77429
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61adada273873bf8f9c08f0bcabf8543a60fb13b
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: net nm: nmdbus connections settings report race fix
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net nm: nmdbus connections settings report race fix
......................................................................
net nm: nmdbus connections settings report race fix
When reporting the connections under nmdbus.settings, a race may exist
between the fetching of the connections paths to the fetching of each
connection content.
When attempting to retrieve the connection content, a missing connection
is now acceptable, assuming that it was removed, therefore not reported
back.
Change-Id: I3589eb4a3369b319d034489523bf900b7a17206d
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/nm/errors.py
M lib/vdsm/network/nm/nmdbus/settings.py
2 files changed, 26 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77795
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3589eb4a3369b319d034489523bf900b7a17206d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years