From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl constants, routing tables
......................................................................
network: isolate libnl constants, routing tables
Change-Id: Ibcf4f15e83dcdaf28bea872ccb668799c8ce11b2
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netinfo/routes.py
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/route.py
3 files changed, 14 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcf4f15e83dcdaf28bea872ccb668799c8ce11b2
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl constants, object type names
......................................................................
network: isolate libnl constants, object type names
Change-Id: I7cadc0a04e982bc7413ad766d68357472cbc83fb
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/monitor.py
3 files changed, 10 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77428
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cadc0a04e982bc7413ad766d68357472cbc83fb
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl constants, NETLINK_ROUTE
......................................................................
network: isolate libnl constants, NETLINK_ROUTE
Change-Id: Id6e12f780e3b62bdf04c761b114c3dbd1661c9c4
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/libnl.py
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77427
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6e12f780e3b62bdf04c761b114c3dbd1661c9c4
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl constants, callback kinds
......................................................................
network: isolate libnl constants, callback kinds
Change-Id: Iaa481a54d60366138dc070225d7b2ed5af9ad01b
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/libnl.py
2 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77425
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa481a54d60366138dc070225d7b2ed5af9ad01b
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: remove unused netlink constant _NLE_NODEV
......................................................................
network: remove unused netlink constant _NLE_NODEV
Change-Id: Icfa06819944d87d48f081c197b23f9f534a97d16
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfa06819944d87d48f081c197b23f9f534a97d16
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: rpc: propagate executor issue to the engine
......................................................................
Patch Set 23: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/74005/23/lib/vdsm/rpc/http.py
File lib/vdsm/rpc/http.py:
Line 281: self.requestHandler = RequestHandlerClass
Line 282:
Line 283: # TODO provide proper limit for this queue
Line 284: # pylint: disable=no-value-for-parameter
Line 285: self.queue = TaskQueue(sys.maxint)
are you sure about this code? this seems like sys.maxint will be used as the queue name here. odd..
Line 286:
Line 287: def add(self, connected_socket, socket_address):
Line 288: self.queue.put((connected_socket, socket_address))
Line 289:
--
To view, visit https://gerrit.ovirt.org/74005
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4038dfd38fa2f9520d822e4c1394bf5bb003e2d
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: WIP: extract Vm.process_devices()
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/77815/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2, Line 1844: extra_xml
extra_xmls ? (to stress it is a list)
--
To view, visit https://gerrit.ovirt.org/77815
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4a3af2ff4a81376ddfbe31d30c43d8b5cf66f39
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Use systemctl directly instead of vdsm-tool where possible
......................................................................
Patch Set 1: Code-Review+1
I prefer that, and later to remove the rest of this module usages.. its not needed anymore, unless vdsm plans to be manager of any kind of services
--
To view, visit https://gerrit.ovirt.org/77784
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icee1b785cd5d869599e5fca3edd8fa84022b4475
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No