Change in vdsm[master]: storage: move to lib/vdsm
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: move to lib/vdsm
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/78070/3/lib/vdsm/storage/blockVolume.py
File lib/vdsm/storage/blockVolume.py:
Line 304: def newVolumeLease(cls, metaId, sdUUID, volUUID):
Line 305: # pylint: disable=no-member
Line 306: cls.log.debug("Initializing volume lease volUUID=%s sdUUID=%s, "
Line 307: "metaId=%s", volUUID, sdUUID, metaId)
Line 308: manifest = vdsm.storage.blockSD.BlockStorageDomainManifest(sdUUID)
> please see my comment in the other file.
I think that I did not understand the problem also when you explained it there.
You cannot use "from vdsm.storage import foo" because of which circular dependency? How does your currently suggested code works around that circular mess?
You don't need to solve all of the existing problems in the code. Moving the code with its illnesses under lib/vdsm/storage is a good step on its own right. But it would be great if you document them more clearly. E.g., have a separate patch saying "Due to a reason unknown to me, pylint complains about cls.log after we move the code to lib/vdsm/storage. This patch silences these errors".
If you cannot break it into a separate patch, a second-best is to add a paragraph about it in the commit message.
Similarly, if you cannot avoid module rename, please explain why.
Line 309: metaSdUUID, mdSlot = metaId
Line 310:
Line 311: leasePath = manifest.getLeasesFilePath()
Line 312: leaseOffset = ((mdSlot + RESERVED_LEASES) *
--
To view, visit https://gerrit.ovirt.org/78070
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1629b9017ddc4d7fece8fb34c1ec63042c6d4d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: sos: fix broken vdsm plugin
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sos: fix broken vdsm plugin
......................................................................
sos: fix broken vdsm plugin
sos report 3.4 leads to this failure:
plugin vdsm does not install, skipping: type object 'Plugin' has no
attribute 'add_copy_spec_limit' a non-existing plugin (vdsm) was
specified in the command line.
add_copy_spec_limit was removed from sosreport Plugin code and replaced
by add_copy_spec function in commit
https://github.com/sosreport/sos/commit/c39a3df3ee1380fc6f2b394912923780f...
This fix replaced add_copy_spec_limit call with add_copy_spec and
removed function __addCopySpecLogLimit since it's not needed anymore.
Change-Id: Ibabbb801a82b985e81c8a5af9ce986ed0b31f019
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1460732
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 14 deletions(-)
Approvals:
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78197
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibabbb801a82b985e81c8a5af9ce986ed0b31f019
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: sos: fix broken vdsm plugin
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: sos: fix broken vdsm plugin
......................................................................
Patch Set 2: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/78197
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibabbb801a82b985e81c8a5af9ce986ed0b31f019
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: network: use six.viewitems/keys for python 3 compatibility
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: use six.viewitems/keys for python 3 compatibility
......................................................................
network: use six.viewitems/keys for python 3 compatibility
Change-Id: Ifa15e7bdfb139cdd53952315ade258aa84a973a3
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/netinfo/qos.py
M lib/vdsm/network/restore_net_config.py
M lib/vdsm/network/tc/cls.py
M tests/functional/networkTests.py
M tests/network/ipwrapper_test.py
6 files changed, 22 insertions(+), 18 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77723
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa15e7bdfb139cdd53952315ade258aa84a973a3
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: network: use six.reraise in python3 compatible way
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: use six.reraise in python3 compatible way
......................................................................
network: use six.reraise in python3 compatible way
Althought six.reraise(NewExc, 'message', tb) works on Python 2,
it is not a valid for Python 3. Python 3 requires second argument
to be an exception instance, body of this instance will be passed
to the first (NewExc) argument.
Change-Id: Icb2d04f3fccda3754640850e7bcc326717429efc
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/ip/route/iproute2.py
M lib/vdsm/network/ip/rule/iproute2.py
2 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb2d04f3fccda3754640850e7bcc326717429efc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: network: decode command output to native string
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: decode command output to native string
......................................................................
network: decode command output to native string
We should keep strings native. With this patch we decode command
output from binary to unicode (in case Python 3 is used) directly
in network.cmd.exec_sync. Thanks to that we handle all strings
natively and we don't end up with errors trying to split binary
with unicode.
This patch fixes Python 3 problems where we handled command output
as a str although it was bytes.
This problem lead into failed tests with Python 3 running. Those
tests could be removed from Python 3 blacklist as soon as we fix
other Python 3 problems.
Change-Id: I39ed13161487cff4f531f513a25a1c74787cf2df
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/cmd.py
M lib/vdsm/network/link/dpdk.py
M tests/Makefile.am
M tests/network/cmd_test.py
M tests/network/dpdk_test.py
M tests/network/nettestlib.py
6 files changed, 49 insertions(+), 28 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39ed13161487cff4f531f513a25a1c74787cf2df
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: ssl: enable tlsv1.2 support
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support
......................................................................
Patch Set 31:
(1 comment)
https://gerrit.ovirt.org/#/c/72284/31/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 271:
Line 272: def protocol_name_to_int():
Line 273: excludes = 0
Line 274:
Line 275: for no_protocol in config.get('vars', 'ssl_protocol').split(','):
> We want to use sslv23 which supports all of the enabled protocols. We can c
There is no NEED for it. But there might be a poor user which already have it set on his vdsm.conf. If you do not add special provisioning for him, he would not be able to start vdsm after upgrade.
Line 276: if no_protocol != '':
Line 277: excludes |= getattr(ssl, no_protocol.strip())
Line 278:
--
To view, visit https://gerrit.ovirt.org/72284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: sos: fix broken vdsm plugin
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: sos: fix broken vdsm plugin
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78197
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibabbb801a82b985e81c8a5af9ce986ed0b31f019
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: ssl: disable sslv3 on centos7
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: disable sslv3 on centos7
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78028
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58c2621a3a93f307dbd1b47596ea842e0adaff5c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: ssl: enable tlsv1.2 support
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support
......................................................................
Patch Set 31: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/72284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years