Change in vdsm[master]: vm: create a vnic with vhostuser backend
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: create a vnic with vhostuser backend
......................................................................
Patch Set 34: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/74327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 34
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: vm: create a vnic with vhostuser backend
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: create a vnic with vhostuser backend
......................................................................
Patch Set 33:
(1 comment)
https://gerrit.ovirt.org/#/c/74327/33/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2250: if self.recovering:
Line 2251: self._dom = virdomain.Notifying(
Line 2252: self._connection.lookupByUUIDString(self.id),
Line 2253: self._timeoutExperienced)
Line 2254: for dev in self._devices[hwclass.NIC]:
> yes, recover() is implemented only in network devices and I had to call it
the effects of this change are more far-reaching than dpdk. *I* feel comfortable with keeping it here. Francesco may want a separate first patch with that introduces the Device.recover() method and explains why its needed.
Line 2255: dev.recover()
Line 2256: elif self._altered_state.origin == _MIGRATION_ORIGIN:
Line 2257: pass # self._dom will be disconnected until migration ends.
Line 2258: elif self._altered_state.origin == _FILE_ORIGIN:
--
To view, visit https://gerrit.ovirt.org/74327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 11 months
Change in vdsm[ovirt-4.1]: sos: fix broken vdsm plugin
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: sos: fix broken vdsm plugin
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/78285
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibabbb801a82b985e81c8a5af9ce986ed0b31f019
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: jsonrpc: fix typo in heartbeat header
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: fix typo in heartbeat header
......................................................................
jsonrpc: fix typo in heartbeat header
HEARTEBEAT is a typo - fixing header constant to HEARTBEAT
Change-Id: I38487ee6c2521948d040edce407c8184ebfab867
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M lib/yajsonrpc/stompreactor.py
M tests/stompadapter_test.py
M tests/stompasyncclient_test.py
4 files changed, 11 insertions(+), 11 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/78284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38487ee6c2521948d040edce407c8184ebfab867
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net,static: Configure NM with slaves-order=name
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net,static: Configure NM with slaves-order=name
......................................................................
net,static: Configure NM with slaves-order=name
NM by default, adds bond slaves based on their index.
In order to be consistent with initscripts ordering, the order is
changed to follow the slaves names instead of the index.
Note: This solution is available from NM version 1.8, part of RHEL 7.4
and Fedora 26.
Change-Id: Ic0e0c740ae8284b9843f114c215d5dad62996837
Bug-Url: https://bugzilla.redhat.com/1443347
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M static/Makefile.am
A static/etc/NetworkManager/conf.d/vdsm.conf
M vdsm.spec.in
3 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77933
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0e0c740ae8284b9843f114c215d5dad62996837
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net,static: Configure NM with slaves-order=name
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net,static: Configure NM with slaves-order=name
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77933
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0c740ae8284b9843f114c215d5dad62996837
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: dump bonding options on network-service start
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: dump bonding options on network-service start
......................................................................
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/78006/10/static/usr/lib/systemd/system/vdsm-...
File static/usr/lib/systemd/system/vdsm-network.service.in:
Line 8: Type=oneshot
Line 9: EnvironmentFile=-/etc/sysconfig/vdsm
Line 10: ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append --logfile=@VDSMLOGDIR(a)/upgrade.log upgrade-networks
Line 11: ExecStart=@BINDIR@/vdsm-tool restore-nets
Line 12: ExecStart=@BINDIR@/vdsm-tool dump-bonding-options
> Why do we need this dump before libvirt service?
Just make sure vdsm-network-init can run without the bonding defaults.
Line 13: RemainAfterExit=yes
Line 14:
Line 15: [Install]
--
To view, visit https://gerrit.ovirt.org/78006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 11 months
Change in vdsm[master]: ssl: enable tlsv1.2 support
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support
......................................................................
Patch Set 31:
(1 comment)
https://gerrit.ovirt.org/#/c/72284/31/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 271:
Line 272: def protocol_name_to_int():
Line 273: excludes = 0
Line 274:
Line 275: for no_protocol in config.get('vars', 'ssl_protocol').split(','):
> OK, so for this specific case we can add additional excludes and keep proto
I don't understand your question.
I would be content you you have
if no_protocol == 'sslv23':
exclude = 0
elif no_protocl == 'tlsv1.1':
exclude = OP_NO_TLSv1
or something like that, for any value that we formerly supported in the config file.
Line 276: if no_protocol != '':
Line 277: excludes |= getattr(ssl, no_protocol.strip())
Line 278:
--
To view, visit https://gerrit.ovirt.org/72284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 11 months
Change in vdsm[master]: net: dump bonding options on network-service start
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: dump bonding options on network-service start
......................................................................
Patch Set 10: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/78006/10/static/usr/lib/systemd/system/vdsm-...
File static/usr/lib/systemd/system/vdsm-network.service.in:
Line 8: Type=oneshot
Line 9: EnvironmentFile=-/etc/sysconfig/vdsm
Line 10: ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append --logfile=@VDSMLOGDIR(a)/upgrade.log upgrade-networks
Line 11: ExecStart=@BINDIR@/vdsm-tool restore-nets
Line 12: ExecStart=@BINDIR@/vdsm-tool dump-bonding-options
> This should appear before the upgrade-networks, as upgrade-networks may try
Should it not appear even earlier, in vdsm-network-init.service ?
Line 13: RemainAfterExit=yes
Line 14:
Line 15: [Install]
--
To view, visit https://gerrit.ovirt.org/78006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 11 months
Change in vdsm[master]: storage: move to lib/vdsm
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: move to lib/vdsm
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/78070/3/lib/vdsm/storage/blockSD.py
File lib/vdsm/storage/blockSD.py:
Line 61:
Line 62: import vdsm.storage.blockVolume
Line 63: import vdsm.storage.resourceFactories as resourceFactories
Line 64: import vdsm.storage.sd as sd
Line 65: import vdsm.storage.sdm as sdm
> We should not have any circular dependencies. If we have such deps, we must
Nir, I think is too tough. For example, sdc imports blockSD which imports blockVolume which imports blockSD and sdc.
These circles exist in the storage code since ever; Piotr must not add any new one, but his patch is a positive step even without solving the existing problems.
In my opinion, it should be enough to explain why a simple
from . import sd
does not work.
Line 66:
Line 67: STORAGE_DOMAIN_TAG = "RHAT_storage_domain"
Line 68: STORAGE_UNREADY_DOMAIN_TAG = STORAGE_DOMAIN_TAG + "_UNREADY"
Line 69:
--
To view, visit https://gerrit.ovirt.org/78070
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1629b9017ddc4d7fece8fb34c1ec63042c6d4d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 11 months