From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support
......................................................................
Patch Set 31:
(1 comment)
https://gerrit.ovirt.org/#/c/72284/31/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 271:
Line 272: def protocol_name_to_int():
Line 273: excludes = 0
Line 274:
Line 275: for no_protocol in config.get('vars',
'ssl_protocol').split(','):
OK, so for this specific case we can add additional excludes and keep
proto
I don't understand your question.
I would be content you you have
if no_protocol == 'sslv23':
exclude = 0
elif no_protocl == 'tlsv1.1':
exclude = OP_NO_TLSv1
or something like that, for any value that we formerly supported in the config file.
Line 276: if no_protocol != '':
Line 277: excludes |= getattr(ssl, no_protocol.strip())
Line 278:
--
To view, visit
https://gerrit.ovirt.org/72284
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes