From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: create a vnic with vhostuser backend
......................................................................
Patch Set 33:
(1 comment)
https://gerrit.ovirt.org/#/c/74327/33/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2250: if self.recovering:
Line 2251: self._dom = virdomain.Notifying(
Line 2252: self._connection.lookupByUUIDString(self.id),
Line 2253: self._timeoutExperienced)
Line 2254: for dev in self._devices[hwclass.NIC]:
yes, recover() is implemented only in network devices and I had to
call it
the effects of this change are more far-reaching than dpdk. *I* feel
comfortable with keeping it here. Francesco may want a separate first patch with that
introduces the Device.recover() method and explains why its needed.
Line 2255: dev.recover()
Line 2256: elif self._altered_state.origin == _MIGRATION_ORIGIN:
Line 2257: pass # self._dom will be disconnected until migration ends.
Line 2258: elif self._altered_state.origin == _FILE_ORIGIN:
--
To view, visit
https://gerrit.ovirt.org/74327
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes