-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/19/#review20
-----------------------------------------------------------
The issue in bug_sync is pretty major and breaks the update sync process. We also need to
figure out how to handle the new information on preferred logging mechanisms that I wrote
about in a comment on #374.
blockerbugs/cli.py
<
http://reviewboard-tflink.rhcloud.com/r/19/#comment35>
See the comment I made on #374 about the way that infra prefers logs to be handled -
while a bit of a pain, hopefully it will help us work around some of the permission issues
we're seeing in addition to not needing to be fixed later
blockerbugs/util/bug_sync.py
<
http://reviewboard-tflink.rhcloud.com/r/19/#comment34>
This line is incorrect and will end up using the logger as a bodhi interface due to
the order of args - either switch to named args here or change the order of args in the
UpdateSync __init__ and make sure that it doesn't break anything
- Tim Flink
On April 3, 2013, 11:53 a.m., Martin Krizek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/19/
-----------------------------------------------------------
(Updated April 3, 2013, 11:53 a.m.)
Review request for blockerbugs.
Bugs: 374
https://fedorahosted.org/fedora-qa/ticket/374
Repository: blockerbugs
Description
-------
This patch reworks logging to both, the application and syncs. Both log to stdout and to
separate files, only if they are configured in config.py though.
Diffs
-----
blockerbugs/util/update_sync.py 7a6af995df3c6aa9d34a6e0ebad9b0fab2d28760
blockerbugs/util/bz_interface.py 2a7a9d128ee87bfb332426a8ada373a9a478a97a
blockerbugs/util/bug_sync.py 2e76680e1701fc3de521a2c3c9f995ae379b944f
blockerbugs/controllers/main.py 6d32e5de91900cda33f5e0342c7854adb24fc8b6
blockerbugs/config.py 2806ca0abb2fefd29505677e76fcf240149dc380
blockerbugs/cli.py 833e27585e427d4ee24f01fc5355469ce07d92ce
blockerbugs/__init__.py 7809b1fc216c764512403acb45e9e0dd836d07de
blockerbugs.spec 3f3e9567b60e2f2482cdbfbab267a2aa47f3feb5
Diff:
http://reviewboard-tflink.rhcloud.com/r/19/diff/
Testing
-------
Thanks,
Martin Krizek