----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/ -----------------------------------------------------------
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description -------
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs -----
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing -------
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/#review67 -----------------------------------------------------------
the sync crashed for me when I tried to run it, will put the tb in trac since I don't know how to do preformatted text in a review.
On a side note, those css diffs make me want to migrate to foundation 4 even more than before - that's a crazy diff for such a small change :-/
- Tim Flink
On Aug. 8, 2013, 11:33 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/
(Updated Aug. 8, 2013, 11:33 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
On Aug. 15, 2013, 4:29 p.m., Tim Flink wrote:
the sync crashed for me when I tried to run it, will put the tb in trac since I don't know how to do preformatted text in a review.
On a side note, those css diffs make me want to migrate to foundation 4 even more than before - that's a crazy diff for such a small change :-/
Could you please put the tb in trac? Thanks!
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/#review67 -----------------------------------------------------------
On Aug. 8, 2013, 11:33 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/
(Updated Aug. 8, 2013, 11:33 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
On Aug. 15, 2013, 4:29 p.m., Tim Flink wrote:
the sync crashed for me when I tried to run it, will put the tb in trac since I don't know how to do preformatted text in a review.
On a side note, those css diffs make me want to migrate to foundation 4 even more than before - that's a crazy diff for such a small change :-/
Martin Krizek wrote: Could you please put the tb in trac? Thanks!
Sorry, I don't know how that didn't get saved in trac - just added it.
- Tim
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/#review67 -----------------------------------------------------------
On Aug. 8, 2013, 11:33 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/
(Updated Aug. 8, 2013, 11:33 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
On Aug. 15, 2013, 4:29 p.m., Tim Flink wrote:
the sync crashed for me when I tried to run it, will put the tb in trac since I don't know how to do preformatted text in a review.
On a side note, those css diffs make me want to migrate to foundation 4 even more than before - that's a crazy diff for such a small change :-/
Martin Krizek wrote: Could you please put the tb in trac? Thanks!
Tim Flink wrote: Sorry, I don't know how that didn't get saved in trac - just added it.
I could not reproduce the tb, I updated the patch though, let me know if that fixes the problem. Thanks!
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/#review67 -----------------------------------------------------------
On Aug. 21, 2013, 8:29 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/
(Updated Aug. 21, 2013, 8:29 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/ -----------------------------------------------------------
(Updated Aug. 21, 2013, 8:29 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description -------
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs (updated) -----
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing -------
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/#review75 -----------------------------------------------------------
sass/app.scss http://reviewboard-tflink.rhcloud.com/r/42/#comment113
This doesn't scream "NEEDINFO" to me. What about using '?' bolded instead of the foundicon font? - ie, use a needinfo class to set the fontsize/color and just put a ? in the span.
sass/app.scss http://reviewboard-tflink.rhcloud.com/r/42/#comment111
using the main color here blends in too much. What do you think about using $fedoraPurple or the same yellow that the "new" indicator uses?
Overall, I like the addition but I would like to see some more visual difference from the surrounding text
- Tim Flink
On Aug. 21, 2013, 8:29 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/
(Updated Aug. 21, 2013, 8:29 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
On Aug. 22, 2013, 8:46 p.m., Martin Krizek wrote:
Overall, I like the addition but I would like to see some more visual difference from the surrounding text
Good point, fixed.
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/#review75 -----------------------------------------------------------
On Aug. 26, 2013, 11:28 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/
(Updated Aug. 26, 2013, 11:28 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/ -----------------------------------------------------------
(Updated Aug. 26, 2013, 11:28 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description -------
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs (updated) -----
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing -------
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/#review82 -----------------------------------------------------------
blockerbugs/static/css/app.css http://reviewboard-tflink.rhcloud.com/r/42/#comment130
I think that not using the same yellow would be better here - color is an easy way to differentiate between the two icons in most cases. Either way, could you make this a constant in _settings.scss instead of a hardcoded value?
maybe darken($fedoraPurple, 10%) or something that isn't that yellow or blue.
still some nitpicking on the color :-/
- Tim Flink
On Aug. 26, 2013, 11:28 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/
(Updated Aug. 26, 2013, 11:28 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
On Aug. 27, 2013, 8:37 p.m., Martin Krizek wrote:
still some nitpicking on the color :-/
Fixed.
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/#review82 -----------------------------------------------------------
On Aug. 26, 2013, 11:28 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/
(Updated Aug. 26, 2013, 11:28 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/ -----------------------------------------------------------
(Updated Aug. 29, 2013, 10:25 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description -------
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs (updated) -----
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c sass/_settings.scss 0365d08d950f4fa3c72223ee9bc32be82cf5d270 blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/general_foundicons.css d46e3b5b5e9452aadedfbb1bc275934a0cea43ec blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing -------
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/#review99 -----------------------------------------------------------
When doing some functional testing on this, I found that if a bug is needinfo and recently modified, the two icons end up above and below eachother in a taller row instead of next to eachother on a normal height row as they should be. I was able to reproduce this in both firefox and chromium.
After futzing with the css and html for a while, I haven't found an awesome solution to this yet. The best I've come up with is to change the <th></th> on the first column to something that's effectively:
<th style="width=50px"></th>
I don't like it but I haven't come up with a better solution. Either way, it needs to be fixed before this code is done.
- Tim Flink
On Aug. 29, 2013, 10:25 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/
(Updated Aug. 29, 2013, 10:25 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c sass/_settings.scss 0365d08d950f4fa3c72223ee9bc32be82cf5d270 blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/general_foundicons.css d46e3b5b5e9452aadedfbb1bc275934a0cea43ec blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
On Sept. 20, 2013, 11:51 p.m., Tim Flink wrote:
When doing some functional testing on this, I found that if a bug is needinfo and recently modified, the two icons end up above and below eachother in a taller row instead of next to eachother on a normal height row as they should be. I was able to reproduce this in both firefox and chromium.
After futzing with the css and html for a while, I haven't found an awesome solution to this yet. The best I've come up with is to change the <th></th> on the first column to something that's effectively:
<th style="width=50px"></th>
I don't like it but I haven't come up with a better solution. Either way, it needs to be fixed before this code is done.
I found out that this happens only when status is longer than 'NEW' (or 'POST' possibly), just a note. Other solution to this would be to delete space character between spans, it is not as hackish as the width one but might not look very good without the space between the two icons. Anyway, I am probably fine with both.
- Martin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/#review99 -----------------------------------------------------------
On Aug. 29, 2013, 10:25 a.m., Martin Krizek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/
(Updated Aug. 29, 2013, 10:25 a.m.)
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c sass/_settings.scss 0365d08d950f4fa3c72223ee9bc32be82cf5d270 blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/general_foundicons.css d46e3b5b5e9452aadedfbb1bc275934a0cea43ec blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/42/ -----------------------------------------------------------
(Updated Nov. 12, 2013, 11:54 a.m.)
Status ------
This change has been marked as submitted.
Review request for blockerbugs.
Bugs: 316 https://fedorahosted.org/fedora-qa/ticket/316
Repository: blockerbugs
Description -------
This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
Diffs -----
sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c sass/_settings.scss 0365d08d950f4fa3c72223ee9bc32be82cf5d270 blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 blockerbugs/static/css/general_foundicons.css d46e3b5b5e9452aadedfbb1bc275934a0cea43ec blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
Testing -------
Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
Thanks,
Martin Krizek
qa-devel@lists.fedoraproject.org