On Mon, Jun 06, Tomas Mraz wrote:
On Mon, 2011-06-06 at 17:12 +0200, Thorsten Kukuk wrote:
> On Thu, Jun 02, Thorsten Kukuk wrote:
> I'm getting now compile errors because of:
>
> pam_namespace.c: In function ‘ns_setup’:
> pam_namespace.c:1542:53: error: ‘MS_PRIVATE’ undeclared (first use in this
function)
> pam_namespace.c:1542:53: note: each undeclared identifier is reported only once for
each function it appears in
> pam_namespace.c:1542:64: error: ‘MS_REC’ undeclared (first use in this function)
> pam_namespace.c: In function ‘pam_sm_close_session’:
> pam_namespace.c:2089:63: warning: to be safe all intermediate pointers in cast from
‘void **’ to ‘const void **’ must be ‘const’ qualified [-Wcast-qual]
>
> Can we catch this somehow in the configure script? I don't know
> if MS_PRIVATE or MS_REC are meanwhile added to glibc, with glibc 2.11 this
> is not the case.
I think that glibc defines are not important, the kernel support is what
matters. The attached patch is correct fix IMO.
The kernel has the defines in linux/fs.h. But they are not included
during compile time.
Patch is fine for me to commit.
Thorsten
--
Thorsten Kukuk, Project Manager/Release Manager SLES
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)