Hi,
I found out that pam_env.so has a "debug" option, which
is described in the manual page, but the variable is never
used. So it's a NOP.
Should we remove it? I would suggest to remove it at least
from the documentation.
Else pam_timestamp as an used variable, Ok to remove it?
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-05-25 Thorsten Kukuk <kukuk(a)thkukuk.de>
+
+ * modules/pam_timestamp/pam_timestamp.c (main): Remove unused
+ variable pretval.
+
2011-05-24 Thorsten Kukuk <kukuk(a)thkukuk.de>
* modules/pam_listfile/pam_listfile.c (pam_sm_authenticate): quiet
--- a/modules/pam_timestamp/pam_timestamp.c
+++ b/modules/pam_timestamp/pam_timestamp.c
@@ -684,7 +684,7 @@ struct pam_module _pam_timestamp_modstruct = {
int
main(int argc, char **argv)
{
- int i, pretval = -1, retval = 0, dflag = 0, kflag = 0;
+ int i, retval = 0, dflag = 0, kflag = 0;
const char *target_user = NULL, *user = NULL, *tty = NULL;
struct passwd *pwd;
struct timeval tv;
@@ -826,7 +826,6 @@ main(int argc, char **argv)
select(STDOUT_FILENO + 1,
NULL, NULL, &write_fds,
&tv);
- pretval = retval;
retval = 0;
}
} while (dflag > 0);
--
Thorsten Kukuk, Project Manager/Release Manager SLES
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)