On Wed, 2019-12-18 at 10:46 +0100, Jan Engelhardt wrote:
On Wednesday 2019-12-18 10:39, Tomas Mraz wrote:
> [doing away with the fullquote as everyone should]
> > Let's rename WARNINGCFLAGS to WARN_CFLAGS - the latter is the
> > name
> > used in other projects I'm familiar with (e.g. strace and gnulib)
>
>
https://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ord...
>
> I named it according to the page above. [...]"we have
> avoided naming the variable of the example LIBFOO_LDFLAGS (with an
> underscore) because that would cause Automake to think that this is
> actually a per-target variable[...]"
That does not apply to xyz_CFLAGS and xyz_LIBS, because, among other
things,
PKG_CHECK_MODULES sets those and would generate pointless warnings.
I would presume it only emits warnings for xyz_SOURCES and things
that need to be known long before make-time, perhaps even configure
time
(...such as sources), so that it can statically analyze all if-ifnot
branches.
OK, I'll commit with the rename.
--
Tomáš Mráz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
[You'll know whether the road is wrong if you carefully listen to your
conscience.]