On Sat, 2020-01-18 at 15:56 +0300, Dmitry V. Levin wrote:
Hi,
On Thu, Dec 19, 2019 at 04:20:17PM +0100, Tomas Mraz wrote:
> On Thu, 2019-12-19 at 16:19 +0100, Tomas Mraz wrote:
> > In many cases it is impossible to avoid casting out the const so
> > I
> > had
> > to add -Wno-cast-qual to individual CFLAGS.
> >
> > IMO explicit cast out should be allowed so we might as well
> > consider
> > dropping this warning flag from the configure.
> >
> > OK to commit as is? Or alternatively I can drop -Wcast-qual from
> > configure.
>
> And now with the patch attached.
First of all, thanks for working on this, and sorry for the long
delay.
All the changes besides -Wno-cast-qual are OK,
wrt -Wcast-qual warnings I think we can do better than adding
-Wno-cast-qual. I suggest we use the pragma-based technique of
temporary
silencing -Wcast-qual compilation warnings where appropriate.
The proposed patch is attached, it should be applied on top of your
non-Wcast-qual fixes. I've also pushed it to
ldv/fix-compilation-warnings branch so you can have a look at travis
build
logs.
OK, I've committed the patch without the -Wno-cast-qual additions.
Please commit your change.
--
Tomáš Mráz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
[You'll know whether the road is wrong if you carefully listen to your
conscience.]