On Wed, 2011-05-25 at 16:11 +0200, Tomas Mraz wrote:
On Wed, 2011-05-25 at 15:48 +0200, Thorsten Kukuk wrote:
> On Wed, May 25, Tomas Mraz wrote:
>
> > On Wed, 2011-05-25 at 15:37 +0200, Thorsten Kukuk wrote:
> > > Hi,
> > >
> > > I found out that pam_env.so has a "debug" option, which
> > > is described in the manual page, but the variable is never
> > > used. So it's a NOP.
> > > Should we remove it? I would suggest to remove it at least
> > > from the documentation.
> > >
> > > Else pam_timestamp as an used variable, Ok to remove it?
> >
> > OK from me for both removing the unused variable in pam_timestamp and
> > the debug option from the pam_env code and man page - there is no need
> > to keep dead code.
>
> I was more afraid of compatibility, but since a wrong option
> will only lead to an error message, but not an abort, I will
> remove it completly.
Or perhaps add some debug logging to make the option useful?
Something like this could be useful. Patch untested.
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb