On Tue, Jan 07, 2014 at 06:45:10PM -0500, Stéphane Graber wrote:
[...]
--- a/modules/pam_loginuid/pam_loginuid.c
+++ b/modules/pam_loginuid/pam_loginuid.c
[...]
- if (set_loginuid(pamh, pwd->pw_uid)) {
+ ret = set_loginuid(pamh, pwd->pw_uid);
+ if (ret != PAM_SUCCESS) {
pam_syslog(pamh, LOG_ERR, "set_loginuid failed\n");
- return PAM_SESSION_ERR;
+ return ret;
}
In addition to other comments,
- pam_syslog(LOG_ERR) in case of PAM_IGNORE does not look like a good idea.
- PAM_SUCCESS is returned later regardless of "ret" value.
--
ldv