On Wed, 2011-11-02 at 16:18 +0400, Dmitry V. Levin wrote:
On Wed, Nov 02, 2011 at 12:41:16PM +0100, Thorsten Kukuk wrote:
> On Wed, Nov 02, Dmitry V. Levin wrote:
>
> > This approach may serve well for normal files where the indentation style
> > is consistent, but how to apply it for pam_selinux.c with its mixed
> > indentation? Should we try to maintain this indentation diversity in one
> > file, or should we better try to bring some consistency in pam_selinux.c
> > before another change which essentially rewrites a large part of this file
> > anyway?
>
> I see two possible options:
>
> - cleanup the indentation without any other change, submit that,
> and base all patches on top of it. But that's only an option
> if Tomas agrees, since this will make backports very difficult.
> - only "fix" the indentation in that area where you make a change
> in a very limited range, so that the real change is still easy
> identificable.
I actually implemented the first option, but if there is a consensus
for the second option, I can rewrite commits to implement it.
I'd really prefer if you just dropped the part of the reindentation
commit above the security_restorelabel_tty() function.
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb