On Thu, Jul 04, 2013 at 10:10:55AM -0400, Richard Guy Briggs wrote:
On Tue, Jul 02, 2013 at 02:43:51AM +0400, Dmitry V. Levin wrote:
> On Thu, Jun 27, 2013 at 03:31:16PM -0400, Richard Guy Briggs wrote:
> > On Fri, Jun 21, 2013 at 08:29:00AM -0400, Richard Guy Briggs wrote:
> > > On Fri, Jun 21, 2013 at 04:38:16AM +0400, Dmitry V. Levin wrote:
> > > > On Tue, Jun 11, 2013 at 11:30:43AM -0400, Richard Guy Briggs wrote:
> > > > > On Mon, Jun 10, 2013 at 04:59:37PM -0400, Richard Guy Briggs
wrote:
> > > > > > On Wed, Jun 05, 2013 at 02:54:09AM +0400, Dmitry V. Levin
wrote:
> > > > > > > On Thu, May 23, 2013 at 10:29:59AM -0400, Richard Guy
Briggs wrote:
> > > > > > > > Most commands are entered one line at a time and
processed as complete lines
> > > > > > > > in non-canonical mode. Commands that
interactively require a password, enter
> > > > > > > > canonical mode with echo set to off to do this.
This feature (icanon and
> > > > > > > > !echo) can be used to avoid logging passwords by
audit while still logging the
> > > > > > > > rest of the command.
> > > > > > > >
> > > > > > > > Adding a member to the struct audit_tty_status
passed in by pam_tty_audit
> > > > > > > > allows control of logging passwords per task.
> > > > > > >
> > > > > > > Sorry for the long delay with review. Please see my
comments below.
> > > > > >
> > > > > > Ditto...
> > > > >
> > > > > Please find a new patch at the end...
> > > >
> > > > The patch looks OK. If commit message contained a ChangeLog-style
entry
> > > > for the change (see README-hacking file), it would be ready for
commit.
> > >
> > > Here you go:
> >
> > I found two bugs in the patch,
>
> Thanks. It appeared to be a typo, so I've committed a simpler fix that
> just replaced all occurrences of HAVE_AUDIT_TTY_STATUS_LOG_PASSWD with
> HAVE_STRUCT_AUDIT_TTY_STATUS_LOG_PASSWD.
Have you tested it? I went through the process to test to make sure
this patch worked. I'm not keen to do it again if I don't need to.
I've tested that generated config.h defines
HAVE_STRUCT_AUDIT_TTY_STATUS_LOG_PASSWD.
--
ldv