https://bugzilla.redhat.com/show_bug.cgi?id=1435559
Bug ID: 1435559 Summary: Review Request: perl-Dist-Milla - CPAN distribution builder Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ppisar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ppisar.fedorapeople.org/perl-Dist-Milla/perl-Dist-Milla.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Dist-Milla/perl-Dist-Milla-1.0.17-1.fc2... Description: Milla is a Dist::Zilla profile. It is a collection of Dist::Zilla plugin bundle, Dist::Zilla minting profile and a command line wrapper. It is designed around the "Convention over Configuration" philosophy, and by default doesn't rewrite module files nor requires you to change your work flow at all.
Fedora Account System Username: ppisar
https://bugzilla.redhat.com/show_bug.cgi?id=1435559
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1435544, 1435550
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1435544 [Bug 1435544] Review Request: perl-Dist-Zilla-Config-Slicer - Config::MVP::Slicer customized for Dist::Zilla https://bugzilla.redhat.com/show_bug.cgi?id=1435550 [Bug 1435550] Review Request: perl-Dist-Zilla-Role-PluginBundle-PluginRemover - Remove plugins from a Dist::Zilla plugin bundle
https://bugzilla.redhat.com/show_bug.cgi?id=1435559 Bug 1435559 depends on bug 1435550, which changed state.
Bug 1435550 Summary: Review Request: perl-Dist-Zilla-Role-PluginBundle-PluginRemover - Remove plugins from a Dist::Zilla plugin bundle https://bugzilla.redhat.com/show_bug.cgi?id=1435550
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1435559 Bug 1435559 depends on bug 1435544, which changed state.
Bug 1435544 Summary: Review Request: perl-Dist-Zilla-Config-Slicer - Config::MVP::Slicer customized for Dist::Zilla https://bugzilla.redhat.com/show_bug.cgi?id=1435544
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1435559
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1435559
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok
$ rpm -qp --requires perl-Dist-Milla-1.0.17-1.fc27.noarch.rpm | sort | uniq -c 1 /usr/bin/perl 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(Dist::Milla) 1 perl(Dist::Milla::App) 1 perl(Dist::Zilla::App) >= 6 1 perl(Dist::Zilla::Plugin::CheckChangesHasContent) 1 perl(Dist::Zilla::Plugin::ConfirmRelease) 1 perl(Dist::Zilla::Plugin::CopyFilesFromBuild) >= 0.163040 1 perl(Dist::Zilla::Plugin::CopyFilesFromRelease) 1 perl(Dist::Zilla::Plugin::ExecDir) 1 perl(Dist::Zilla::Plugin::ExtraTests) 1 perl(Dist::Zilla::Plugin::Git::Contributors) >= 0.009 1 perl(Dist::Zilla::Plugin::Git::GatherDir) 1 perl(Dist::Zilla::Plugin::Git::Init) >= 2.012 1 perl(Dist::Zilla::Plugin::GithubMeta) 1 perl(Dist::Zilla::Plugin::InlineFiles) 1 perl(Dist::Zilla::Plugin::License) 1 perl(Dist::Zilla::Plugin::LicenseFromModule) >= 0.05 1 perl(Dist::Zilla::Plugin::Manifest) 1 perl(Dist::Zilla::Plugin::MetaJSON) 1 perl(Dist::Zilla::Plugin::MetaYAML) 1 perl(Dist::Zilla::Plugin::ModuleBuildTiny) 1 perl(Dist::Zilla::Plugin::NameFromDirectory) >= 0.04 1 perl(Dist::Zilla::Plugin::NextRelease) 1 perl(Dist::Zilla::Plugin::PodSyntaxTests) 1 perl(Dist::Zilla::Plugin::Prereqs::FromCPANfile) >= 0.06 1 perl(Dist::Zilla::Plugin::ReadmeAnyFromPod) 1 perl(Dist::Zilla::Plugin::ReadmeFromPod) 1 perl(Dist::Zilla::Plugin::ReversionOnRelease) >= 0.04 1 perl(Dist::Zilla::Plugin::ShareDir) 1 perl(Dist::Zilla::Plugin::Test::Compile) 1 perl(Dist::Zilla::Plugin::TestRelease) 1 perl(Dist::Zilla::Plugin::UploadToCPAN) 1 perl(Dist::Zilla::Plugin::VersionFromModule) 1 perl(Dist::Zilla::PluginBundle::Git) 1 perl(Dist::Zilla::Role::AfterMint) 1 perl(Dist::Zilla::Role::MetaProvider) 1 perl(Dist::Zilla::Role::MintingProfile::ShareDir) 1 perl(Dist::Zilla::Role::PluginBundle::Config::Slicer) 1 perl(Dist::Zilla::Role::PluginBundle::Easy) 1 perl(Dist::Zilla::Role::PluginBundle::PluginRemover) 1 perl(Dist::Zilla::Role::TextTemplate) 1 perl(File::pushd) 1 perl(Git::Wrapper) 1 perl(Module::CPANfile) >= 0.9025 1 perl(Moose) 1 perl(namespace::autoclean) 1 perl(parent) 1 perl(strict) 1 perl(version) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -qp --provides perl-Dist-Milla-1.0.17-1.fc27.noarch.rpm | sort | uniq -c 1 perl(Dist::Milla) = 1.0.17 1 perl(Dist::Milla::App) = 1.0.17 1 perl(Dist::Zilla::MintingProfile::Milla) 1 perl(Dist::Zilla::Plugin::Milla::FirstBuild) 1 perl(Dist::Zilla::Plugin::Milla::MetaGeneratedBy) 1 perl(Dist::Zilla::Plugin::Milla::MintFiles) 1 perl(Dist::Zilla::PluginBundle::Milla) = 1.0.17 1 perl(Milla) 1 perl-Dist-Milla = 1.0.17-1.fc27 Binary provides are Ok.
$ rpmlint ./perl-Dist-Milla* perl-Dist-Milla.src: W: spelling-error %description -l en_US Zilla -> Villa, Willa, Mozilla 2 packages and 1 specfiles checked; 0 errors, 1 warnings. Rpmlint is ok
The package looks good. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1435559
--- Comment #2 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Milla
https://bugzilla.redhat.com/show_bug.cgi?id=1435559
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Dist-Milla-1.0.17-1.fc | |27 Resolution|--- |RAWHIDE Last Closed| |2017-04-03 09:02:06
--- Comment #3 from Petr Pisar ppisar@redhat.com --- Thank you for this review and all the required reviews. And thanks for creating the repository.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com