https://bugzilla.redhat.com/show_bug.cgi?id=1424860

--- Comment #6 from Piotr Popieluch piotr1212@gmail.com --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/piotr /fedora-scm/1424860-nodejs-finalhandler/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).

Rpmlint ------- Checking: nodejs-finalhandler-1.0.0-3.fc27.noarch.rpm nodejs-finalhandler-1.0.0-3.fc27.src.rpm nodejs-finalhandler.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-finalhandler.noarch: W: spelling-error Summary(en_US) http -> HTTP nodejs-finalhandler.noarch: W: spelling-error Summary(en_US) responder -> responded, res ponder, res-ponder nodejs-finalhandler.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-finalhandler.noarch: W: spelling-error %description -l en_US http -> HTTP nodejs-finalhandler.noarch: W: spelling-error %description -l en_US responder -> responded, res ponder, res-ponder nodejs-finalhandler.noarch: W: only-non-binary-in-usr-lib nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/unpipe /usr/lib/node_modules/unpipe nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/statuses /usr/lib/node_modules/statuses nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/encodeurl /usr/lib/node_modules/encodeurl nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/on-finished /usr/lib/node_modules/on-finished nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/debug /usr/lib/node_modules/debug nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/escape-html /usr/lib/node_modules/escape-html nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/parseurl /usr/lib/node_modules/parseurl nodejs-finalhandler.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-finalhandler.src: W: spelling-error Summary(en_US) http -> HTTP nodejs-finalhandler.src: W: spelling-error Summary(en_US) responder -> responded, res ponder, res-ponder nodejs-finalhandler.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-finalhandler.src: W: spelling-error %description -l en_US http -> HTTP nodejs-finalhandler.src: W: spelling-error %description -l en_US responder -> responded, res ponder, res-ponder 2 packages and 0 specfiles checked; 0 errors, 20 warnings.

Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory nodejs-finalhandler.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-finalhandler.noarch: W: spelling-error Summary(en_US) http -> HTTP nodejs-finalhandler.noarch: W: spelling-error Summary(en_US) responder -> responded, res ponder, res-ponder nodejs-finalhandler.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-finalhandler.noarch: W: spelling-error %description -l en_US http -> HTTP nodejs-finalhandler.noarch: W: spelling-error %description -l en_US responder -> responded, res ponder, res-ponder nodejs-finalhandler.noarch: W: only-non-binary-in-usr-lib nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/debug /usr/lib/node_modules/debug nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/encodeurl /usr/lib/node_modules/encodeurl nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/escape-html /usr/lib/node_modules/escape-html nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/on-finished /usr/lib/node_modules/on-finished nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/parseurl /usr/lib/node_modules/parseurl nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/statuses /usr/lib/node_modules/statuses nodejs-finalhandler.noarch: W: dangling-symlink /usr/lib/node_modules/finalhandler/node_modules/unpipe /usr/lib/node_modules/unpipe 1 packages and 0 specfiles checked; 0 errors, 14 warnings.

Diff spec file in url and in SRPM --------------------------------- --- /home/piotr/fedora-scm/1424860-nodejs-finalhandler/srpm/nodejs-finalhandler.spec 2017-03-15 22:12:45.407223702 +0100 +++ /home/piotr/fedora-scm/1424860-nodejs-finalhandler/srpm-unpacked/nodejs-finalhandler.spec 2017-03-14 17:33:32.000000000 +0100 @@ -26,4 +26,10 @@ BuildRequires: npm(supertest) BuildRequires: npm(encodeurl) +BuildRequires: npm(debug) +BuildRequires: npm(escape-html) +BuildRequires: npm(on-finished) +BuildRequires: npm(parseurl) +BuildRequires: npm(statuses) +BuildRequires: npm(unpipe) %endif

Requires -------- nodejs-finalhandler (rpmlib, GLIBC filtered): nodejs(engine) npm(debug) npm(encodeurl) npm(escape-html) npm(on-finished) npm(parseurl) npm(statuses) npm(unpipe)

Provides -------- nodejs-finalhandler: nodejs-finalhandler npm(finalhandler)

Source checksums ---------------- https://github.com/pillarjs/finalhandler/archive/v1.0.0.tar.gz : CHECKSUM(SHA256) this package : 86f34458375ca7c9cf3fd79545be23633af73a4e603c84eff45c3f257049d933 CHECKSUM(SHA256) upstream package : 86f34458375ca7c9cf3fd79545be23633af73a4e603c84eff45c3f257049d933

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1424860 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6