Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=844621
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #4 from Petr Pisar <ppisar(a)redhat.com> ---
Spec file changes:
--- perl-Log-Contextual.spec.old 2013-01-30 14:40:54.000000000 +0100
+++ perl-Log-Contextual.spec 2013-02-05 17:39:45.000000000 +0100
@@ -12,16 +12,18 @@
BuildRequires: perl(Carp)
BuildRequires: perl(Data::Dumper::Concise)
BuildRequires: perl(Exporter::Declare) >= 0.105
-BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(Exporter::Declare::Export::Generator)
BuildRequires: perl(File::Temp)
BuildRequires: perl(lib)
BuildRequires: perl(Log::Log4perl) >= 1.29
BuildRequires: perl(Scalar::Util)
-BuildRequires: perl(Test::Fatal)
BuildRequires: perl(Test::More)
Requires: perl(Exporter::Declare) >= 0.105
Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
+# Filter under-specified depenedencies
+%global __requires_exclude
%{?__provides_exclude:%__provides_exclude|}^perl\\(Exporter::Declare\\)\\s*$
+
%description
This module is a simple interface to extensible logging. It is bundled with
a really basic logger, Log::Contextual::SimpleLogger, but in general you
@@ -39,7 +41,7 @@
make %{?_smp_mflags}
%install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
%{_fixperms} $RPM_BUILD_ROOT/*
@@ -54,6 +56,8 @@
%changelog
* Wed Jan 30 2013 Jitka Plesnikova <jplesnik(a)redhat.com> - 0.004300-1
- 0.004300 bump
+- Update BRs.
+- Replace PERL_INSTALL_ROOT with DESTDIR.
-* Tue Jul 21 2012 Jitka Plesnikova <jplesnik(a)redhat.com> - 0.004201-1
+* Tue Jul 24 2012 Jitka Plesnikova <jplesnik(a)redhat.com> - 0.004201-1
- Specfile autogenerated by cpanspec 1.78.
TODO: You can use DESTDIR argument instead of PERL_INSTALL_ROOT in
%install section.
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
Ok.
TODO: Remove useless build-require `perl(ExtUtils::MakeMaker)'.
All occurrences are in removed inc/.
-BuildRequires: perl(ExtUtils::MakeMaker)
Ok.
FIX: Remove useless build-require `perl(Test::Fatal)'. It's
not used anywhere.
-BuildRequires: perl(Test::Fatal)
Ok.
FIX: Build-require `perl(Exporter::Declare::Export::Generator)'
(lib/Log/Contextual.pm:11).
+BuildRequires:
perl(Exporter::Declare::Export::Generator)
Ok.
FIX: Use valid date in changelog entry.
-* Tue Jul 21 2012
Jitka Plesnikova <jplesnik(a)redhat.com> - 0.004201-1
+* Tue Jul 24 2012 Jitka Plesnikova <jplesnik(a)redhat.com> - 0.004201-1
Ok.
$ rpmlint perl-Log-Contextual.spec
../SRPMS/perl-Log-Contextual-0.004300-1.fc19.src.rpm
../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm
perl-Log-Contextual.src: W: spelling-error %description -l en_US SimpleLogger
-> Simple Logger, Simple-logger, Oversimple
perl-Log-Contextual.src: W: spelling-error %description -l en_US Dispatchouli
-> Dis patchouli, Dis-patchouli, Patchouli
perl-Log-Contextual.noarch: W: spelling-error %description -l en_US
SimpleLogger -> Simple Logger, Simple-logger, Oversimple
perl-Log-Contextual.noarch: W: spelling-error %description -l en_US
Dispatchouli -> Dis patchouli, Dis-patchouli, Patchouli
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.
TODO: Do not require unversioned `perl(Exporter::Declare)'.
$ rpm -q --requires -p
../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm | sort | uniq -c
1 perl(Carp)
1 perl(Data::Dumper::Concise)
1 perl(Exporter::Declare) >= 0.105
1 perl(Exporter::Declare::Export::Generator)
1 perl(:MODULE_COMPAT_5.16.2)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
Package builds in F19
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=4932144). Ok.
Package is good.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=V90yLmFqZK&a=cc_unsubscribe