Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891873
--- Comment #5 from Petr Pisar <ppisar(a)redhat.com> ---
Spec file changes:
--- perl-Net-IDN-Nameprep.spec.old 2013-01-04 11:22:13.000000000 +0100
+++ perl-Net-IDN-Nameprep.spec 2013-01-23 05:44:32.000000000 +0100
@@ -1,19 +1,22 @@
Name: perl-Net-IDN-Nameprep
Summary: Stringprep Profile for Internationalized Domain Names (RFC
3491)
Version: 1.101
-Release: 1%{?dist}
+Release: 2%{?dist}
License: GPL+ or Artistic
URL:
http://search.cpan.org/dist/Net-IDN-Nameprep/
Source0:
http://www.cpan.org/authors/id/C/CF/CFAERBER/Net-IDN-Nameprep-%{version}....
BuildArch: noarch
+BuildRequires: perl(Exporter)
BuildRequires: perl(Module::Build)
BuildRequires: perl(Test::More)
BuildRequires: perl(Test::NoWarnings)
BuildRequires: perl(Unicode::Stringprep) >= 1.1
+BuildRequires: perl(Unicode::Stringprep::Mapping)
+BuildRequires: perl(Unicode::Stringprep::Prohibited)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
%{?perl_default_filter}
@@ -29,9 +32,19 @@
%prep
%setup -q -n Net-IDN-Nameprep-%{version}
+# Remove incorrect executable bits
+chmod -x Changes \
+ lib/Net/IDN/Nameprep.pm
+
+# Convert files to UTF-8
+for FILE in LICENSE README; do
+ iconv -f ISO_8859-1 -t UTF8 $FILE > $FILE.utf8
+ mv $FILE.utf8 $FILE
+done
+
%build
-%{__perl} Build.PL installdirs=vendor
+perl Build.PL installdirs=vendor
./Build
@@ -52,5 +65,11 @@
%changelog
+* Wed Jan 23 2013 Mathieu Bridon <mathieu.bridon(a)network-box.com> - 1.101-2
+- Replace the usage of the %%{__perl} macro by the plain perl command.
+- Add missing build requirements.
+- Remove the incorrect executable bits.
+- Make sure all files are UTF-8 encoded.
+
* Fri Jan 04 2013 Mathieu Bridon <bochecha(a)fedoraproject.org> - 1.101-1
- Initial package for Fedora, with help from cpanspec.
TODO: You can replace %{__perl} macro with plain perl.
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
echo
$version))
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
Ok.
TODO: Build-require `perl(Exporter)'
(lib/Net/IDN/Nameprep.pm:10).
+BuildRequires: perl(Exporter)
Ok.
FIX: Build-require `perl(Unicode::Stringprep::Mapping)'
(lib/Net/IDN/Nameprep.pm:16).
+BuildRequires: perl(Unicode::Stringprep::Mapping)
Ok.
FIX: Build-require `perl(Unicode::Stringprep::Prohibited)'
(lib/Net/IDN/Nameprep.pm:17).
+BuildRequires:
perl(Unicode::Stringprep::Prohibited)
Ok.
FIX: Remove executable bit from Changes file.
FIX: Remove executable bit from Nameprep.pm.
FIX: Remove executable bit from /usr/share/doc/perl-Net-IDN-Nameprep-1.101/Changes and
/usr/share/perl5/vendor_perl/Net/IDN/Nameprep.pm.
+chmod -x Changes \
+ lib/Net/IDN/Nameprep.pm
Ok.
FIX: Convert LICENSE and README to UTF-8.
+# Convert files to
UTF-8
+for FILE in LICENSE README; do
+ iconv -f ISO_8859-1 -t UTF8 $FILE > $FILE.utf8
+ mv $FILE.utf8 $FILE
+done
Ok.
$ rpmlint perl-Net-IDN-Nameprep.spec
../SRPMS/perl-Net-IDN-Nameprep-1.101-2.fc19.src.rpm
../RPMS/noarch/perl-Net-IDN-Nameprep-1.101-2.fc19.noarch.rpm
perl-Net-IDN-Nameprep.src: W: spelling-error Summary(en_US) Stringprep ->
String prep, String-prep, Stripping
perl-Net-IDN-Nameprep.src: W: spelling-error %description -l en_US stringprep
-> string prep, string-prep, stripping
perl-Net-IDN-Nameprep.noarch: W: spelling-error Summary(en_US) Stringprep ->
String prep, String-prep, Stripping
perl-Net-IDN-Nameprep.noarch: W: spelling-error %description -l en_US
stringprep -> string prep, string-prep, stripping
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Net-IDN-Nameprep-1.101-2.fc19.noarch.rpm
drwxr-xr-x 2 root root 0 Jan 23 10:07
/usr/share/doc/perl-Net-IDN-Nameprep-1.101
-rw-r--r-- 1 root root 1176 Dec 8 2011
/usr/share/doc/perl-Net-IDN-Nameprep-1.101/Changes
-rw-r--r-- 1 root root 18410 Jan 23 10:07
/usr/share/doc/perl-Net-IDN-Nameprep-1.101/LICENSE
-rw-r--r-- 1 root root 770 Jan 23 10:07
/usr/share/doc/perl-Net-IDN-Nameprep-1.101/README
-rw-r--r-- 1 root root 2732 Jan 23 10:07
/usr/share/man/man3/Net::IDN::Nameprep.3pm.gz
drwxr-xr-x 2 root root 0 Jan 23 10:07
/usr/share/perl5/vendor_perl/Net
drwxr-xr-x 2 root root 0 Jan 23 10:07
/usr/share/perl5/vendor_perl/Net/IDN
-rw-r--r-- 1 root root 3004 Jan 23 10:07
/usr/share/perl5/vendor_perl/Net/IDN/Nameprep.pm
File layout and permissions are Ok.
Package builds in F19
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=4896073). Ok.
Package is good except the unclarified license.
Resolution: Waiting on legal.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=XjBbtWTqiA&a=cc_unsubscribe